Skip to content

Refactor cluster printing #455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jakobnissen merged 2 commits into from
Aug 27, 2025
Merged

Refactor cluster printing #455

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5361a88
Refactor cluster printing
jakobnissen Aug 27, 2025
be4c69f
Fixup
jakobnissen Aug 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions test/test_vambtools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -537,14 +537,14 @@ def test_bad_params(self):
# Too many bins for maxbins
with self.assertRaises(ValueError):
vamb.vambtools.write_bins(
self.dir, self.bins, self.file, maxbins=self.N_BINS - 1
self.dir, self.bins.items(), self.file, maxbins=self.N_BINS - 1
)

# Parent does not exist
with self.assertRaises(NotADirectoryError):
vamb.vambtools.write_bins(
pathlib.Path("svogew/foo"),
self.bins,
self.bins.items(),
self.file,
maxbins=self.N_BINS + 1,
)
Expand All @@ -554,7 +554,7 @@ def test_bad_params(self):
with tempfile.NamedTemporaryFile() as file:
vamb.vambtools.write_bins(
pathlib.Path(file.name),
self.bins,
self.bins.items(),
self.file,
maxbins=self.N_BINS + 1,
)
Expand All @@ -564,14 +564,14 @@ def test_bad_params(self):
bins = {k: v.copy() for k, v in self.bins.items()}
next(iter(bins.values())).add("a_new_bin_which_does_not_exist")
vamb.vambtools.write_bins(
self.dir, bins, self.file, maxbins=self.N_BINS + 1
self.dir, bins.items(), self.file, maxbins=self.N_BINS + 1
)

def test_round_trip(self):
with tempfile.TemporaryDirectory() as dir:
vamb.vambtools.write_bins(
pathlib.Path(dir),
self.bins,
self.bins.items(),
self.file,
maxbins=self.N_BINS,
)
Expand Down
Loading