-
Notifications
You must be signed in to change notification settings - Fork 7
135 make pololu maestro driver be possible to use in uart mode as well #175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
heevasti
wants to merge
14
commits into
main
Choose a base branch
from
135-make-pololu-maestro-driver-be-possible-to-use-in-uart-mode-as-well
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
135 make pololu maestro driver be possible to use in uart mode as well #175
heevasti
wants to merge
14
commits into
main
from
135-make-pololu-maestro-driver-be-possible-to-use-in-uart-mode-as-well
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ting UART creates issues. This is due to the import structure of the adafruit-blinka
…ts. Now setting more patching for imports in `test_maestro.py``but this means we need to separately test `qmi_uart.py` as we mock most of it.
…ts. Now setting more patching for imports in `test_maestro.py``but this means we need to separately test `qmi_uart.py` as we mock most of it.
…ue to high level of mocking, a hardware testing should be also done before review.
…y` since changes in `psutil` version 7.2.0.
…y` since changes in `psutil` version 7.2.0.
…y` since changes in `psutil` version 7.2.0.
…y` since changes in `psutil` version 7.2.0.
…nal in scheduled-full-ci.yml.
…nal in scheduled-full-ci.yml.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pololu Maestro QMI driver was updated so that it can be used also with Pololu instruments that are in the default UART mode, by using a special "uart:..." transport string. For this we need
boardandbusiomodules fromadafruit-blinkapackage, which are imported as "lazy imports". The latter is imported through newqmi_uartmodule, which has an extension of thebusio.UARTclass so that it is compatible withQMI_Transportclasses to use with the special transport string, and to use the same read-write calls.During the course of this refactoring and extension, also the
psutilpackage was updated such that it would not work anymore inqmi_proc.py. This is due to moving the_snicaddrinternal variable in the package. Theqmi_proc.pywas adapted such that it checks the version number ofpsutiland selects followingly the correct location of the_snicaddr.