Module banners update #914
Conversation
enryH
left a comment
enryH
left a comment
There was a problem hiding this comment.
I would say the message is repeated too often in the same page (with 4 tabs). Can you consider to create a function for it, so it can be changed in one place only?
Co-authored-by: Henry Webel <heweb@dtu.dk>
Sure, well, at least now the message in the banner is only on one location. |
| st.warning( | ||
| "This module is in BETA phase. The figure presented below and the metrics calculation may change in the near future." | ||
| else: | ||
| if self.variables_dia_quant.alpha_warning: |
There was a problem hiding this comment.
this is repeated from above. I am not sure how you want the warnings exactly to display, but I think this can go into an function, checking ing if the configuration sets these flags and then it calls the display method.
There was a problem hiding this comment.
I have done it for one module now (10_), but if all use the same structure it should be easy to do for the rest. See my last commit.
There was a problem hiding this comment.
Thanks a lot. I'll make the changes for the other modules :) Hopefully today
Hi,
the main aim was to modify the banner of the archived module (it was still "beta").
In the end I reorganised the banner text and conditions. Could you check?
I add the ShortMessages of the generic text document the messages for the banners (alpha, beta and archived).
And I modified the module pages accordingly.
Could you please confirm that you are OK with this new system for the banners? I'll work on some documentation for the Alpha. Put it somewhere.
Question:
Why are there 2 documents for the generic texts? One for DIA and one for DDA? Are these both used?