Fetch pull request #718
Draft
Fetch pull request #718
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DDAQuantIonModule has been removed and changed with DDAQuantIonModuleQExactive
enryH
reviewed
Jun 29, 2025
| def get_repo(self, repo_name: str): | ||
| return self.github.get_repo(repo_name) | ||
|
|
||
| @staticmethod |
Member
There was a problem hiding this comment.
I am fan to move staticmethod out of the class in the general module context. And if you really want, then you could add it again to the class scope. If I need to provide more context I would copy a discussion in fluent python on that topic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A class for fetching pull requests