Use asn1js.Integer.fromBigInt instead of asn1js.Integer #456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keeping up to date
…sn1js.Integer.fromBigInt
microshine
requested changes
Nov 6, 2025
Contributor
microshine
left a comment
microshine
left a comment
There was a problem hiding this comment.
Thanks for the fix, looks correct and should resolve the P‑521 encoding issue. I left a few small remarks in the review.
Author
|
@microshine i hope the new test works. If there is anything else to fix, please let me know. :) |
gtjarks
suggested changes
Dec 10, 2025
gtjarks
approved these changes
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The r and s values returned by the WebCryptoAPI are assigned as byte buffers to the asn1js.Integer class (new asn1js.Integer({ valueHex: rBuffer });).
The WebCryptoAPI does not apply any formatting to these values; it outputs byte arrays whose lengths correspond to the bit length (order) of the elliptic curve. As a result, smaller numerical values are left-padded with 0x00 bytes, which can lead to invalid or misinterpreted ASN.1 encodings. See asn1IntTest.spec.ts.
As a solution we propose to convert to BigInt and use the asn1js.Integer.fromBigInt method.
This should solve #385