fix: re-add filtering by map name to /sponsor maps
#97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Re-adds name filtering to `/sponsor maps`, which was (probably accidentally) removed by b6bad75. Search implementation was copied over from MapLibrary#getMaps(String) in PGM. Additionally, SponsorManager#getAvailableSponsorMaps() has been changed to use MapLibrary#getMaps(String) instead of the zero-arity function to avoid stream copies. Signed-off-by: TTtie <me@tttie.cz>
TTtie
force-pushed
the
fix/sponsor-map-name-filtering
branch
from
ee0e1f3 to
c3994f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-adds name filtering to
/sponsor maps, which was (probably unintentionally) removed by b6bad75. Search implementation was copied over fromMapLibrary#getMaps(String)in PGM.Additionally,
SponsorManager#getAvailableSponsorMaps()has been changed to useMapLibrary#getMaps(String)instead of the zero-arity method to avoid stream copies. (Maybe the search query could be passed down to PGM instead of manually filtering it afterwards?)