Fix repeat reset for scan prefix #875
Conversation
NWilson
left a comment
NWilson
left a comment
There was a problem hiding this comment.
I agree, I'll tag it for backporting since it affects match correctness. Thanks for fixing so quickly.
|
The static analyzer complains about non signed packages. Probably it needs some update. |
| repeat = GET2(cc, 1); | ||
| if (repeat <= 0) | ||
| { | ||
| repeat = 1; |
There was a problem hiding this comment.
considering that this code was released with 10.41, is the bug really a regression for 10.45?
nevermind, had to remember that we have a non linear history now:
$ git describe --tags 6f2da25f0
pcre2-10.44-145-g6f2da25f
$ git describe 6f2da25f0
pcre2-10.40-466-g6f2da25f
There was a problem hiding this comment.
I will recommend it for backporting as far back as the bug goes. The original report just says 10.45+, but if it affects earlier, I'll check the patch and see what's needed.
There was a problem hiding this comment.
the original report was correct about the versions affected, but seem to had gotten the wrong changeset as a culprit.
the code that was patched was released with 10.45 (which is what 10.44 tag + 145 commits) means in the output of git describe --tags
|
I plan to land this patch. Does anybody has any objection? |
|
I'm happy, I approved |
3 participants
If this fixes the problem in #874, maybe this could be a candidate for maintenance patch.