[18.0][MIG] purchase_compute_order: Migration to 18.0 #2

P-H-Phuc · 2025-11-24T09:01:21Z

This module depends on:
- product_average_comsumption
- purchase_package_qty

* [ADD] Added new feature to sort Computed PO lines * [ADD] Added new feauture to see Computed purchase order lines, Improved fr translations

[ADD] icon.png

Currently translated at 100.0% (178 of 178 strings) Translation: foodcoops-12.0/foodcoops-12.0-purchase_compute_order Translate-URL: https://translate.druidoo.io/projects/foodcoops-12-0/foodcoops-12-0-purchase_compute_order/fr/

Currently translated at 100.0% (178 of 178 strings) Translation: foodcoops-12.0/foodcoops-12.0-purchase_compute_order Translate-URL: https://translate.druidoo.io/projects/foodcoops-12-0/foodcoops-12-0-purchase_compute_order/fr/ [FIX] Order of lines in Calculated Purchase Order [FIX] CPO performance issue (S#26472) [FIX] S#26688: Cann’t order from Viome [ADD] S#T34632 - Delivery Categories [ADD] F#T59775 - Minimum Quantity for products in Calculated purchase order F#T60423 - Add column Nb. Package MAX [ADD] F#T60745 - Add Shelf Life information [UPD] F#T60886 - Save Purchase Target in CPO after order PO created [UPD] F#T60885 - Adjustment to Product History Pop-up in CPO [UPD] F#T61877 - [SQQ-VDM] Missing translation in FR

nguyenminhchien

tests failed

nguyenminhchien

Add product_packaging_id to the flow: product.supplierinfo => CPO => PO =>...
Remember to show the package things for the group product.group_stock_packaging only.

nguyenminhchien · 2025-11-27T09:18:01Z

purchase_compute_order/models/computed_purchase_order_line.py

+        compute="_compute_subtotal_price",
+        digits="Product Price",
+    )
+    package_qty = fields.Float("Package quantity")


Add new field product_packaging_id m2o to product.packaging

package_qty = fields.Float(related="product_packaging_id.qty", store=True,...)

nguyenminhchien · 2025-11-27T09:19:13Z

purchase_compute_order/views/computed_purchase_order_line_view.xml

+                <field name="uom_id" />
+                <field name="stock_duration" />
+                <field name="cpo_state" invisible="1" />
+                <field name="purchase_qty_package" />


Show product_packaging_id to the UI.

Add groups="product.group_stock_packaging" for all the fields related to the package

nguyenminhchien

Tests still failed from fresh db:

 
2025-12-04 02:28:28,667 22467 INFO v18c_purchase_compute_order odoo.addons.purchase_compute_order.tests.test_purchase_compute_order: Starting TestPurchaseComputeOrder.test_003_make_purchase_order ... 
2025-12-04 02:28:28,721 22467 INFO v18c_purchase_compute_order odoo.addons.purchase_compute_order.tests.test_purchase_compute_order: ====================================================================== 
2025-12-04 02:28:28,721 22467 ERROR v18c_purchase_compute_order odoo.addons.purchase_compute_order.tests.test_purchase_compute_order: ERROR: TestPurchaseComputeOrder.test_003_make_purchase_order
Traceback (most recent call last):
  File "/home/chien/code/oca/purchase-workflow/18.0/purchase_compute_order/tests/test_purchase_compute_order.py", line 68, in test_003_make_purchase_order
    self.cmp_purchase_order.compute_purchase_quantities()
  File "/home/chien/code/oca/purchase-workflow/18.0/purchase_compute_order/models/computed_purchase_order.py", line 492, in compute_purchase_quantities
    return cpo._compute_purchase_quantities_days()
  File "/home/chien/code/oca/purchase-workflow/18.0/purchase_compute_order/models/computed_purchase_order.py", line 369, in _compute_purchase_quantities_days
    line.purchase_qty_package = quantity / package_qty
ZeroDivisionError: float division by zero

nguyenminhchien

Add product_packaging_id to the flow: product.supplierinfo => CPO => PO =>...

You missed this point.
I cannot test further without that feature.

nguyenminhchien · 2025-12-04T02:53:33Z

purchase_compute_order/views/computed_purchase_order_line_view.xml

+                <field name="purchase_qty" />
+                <field name="product_price_inv" />
+                <field name="discount_inv" />
+                <field name="price_policy" />


Suggested change

<field name="price_policy" />

<field name="price_policy" groups="product.group_stock_packaging"/>

nguyenminhchien · 2025-12-04T02:53:54Z

purchase_compute_order/views/computed_purchase_order_view.xml

+                                    <field name="purchase_qty" readonly="1" />
+                                    <field name="product_price_inv" readonly="1" />
+                                    <field name="discount_inv" readonly="1" />
+                                    <field name="price_policy" readonly="1" />


Suggested change

<field name="price_policy" readonly="1" />

<field name="price_policy" readonly="1" groups="product.group_stock_packaging" />

nguyenminhchien · 2025-12-04T02:55:12Z

purchase_compute_order/views/computed_purchase_order_view.xml

+                                            </div>
+                                            <field name="product_price_inv" />
+                                            <field name="discount_inv" />
+                                            <field name="price_policy" />


Suggested change

<field name="price_policy" />

<field name="price_policy" groups="product.group_stock_packaging"/>

nguyenminhchien · 2025-12-04T02:59:45Z

purchase_compute_order/wizard/update_products_wizard.py

+        required=True,
+        help="""This comes from the product form.""",
+    )
+    package_qty = fields.Float(


Wherever package_qty is, add product_packaging_id and change package_qty to be a related field.

nguyenminhchien · 2025-12-04T03:01:43Z

purchase_compute_order/wizard/update_products_wizard.py

+                            "product_code": line.product_code,
+                            "product_name": line.product_name,
+                            "product_uom": line.uom_po_id.id,
+                            "package_qty": line.package_qty,


Suggested change

"package_qty": line.package_qty,

"product_packaging_id": line.product_packaging_id,

nguyenminhchien · 2025-12-04T03:01:55Z

purchase_compute_order/wizard/update_products_wizard.py

+                    "product_name": line.product_name,
+                    "product_code": line.product_code,
+                    "product_uom": line.product_uom.id,
+                    "package_qty": line.package_qty,


Suggested change

"package_qty": line.package_qty,

"product_packaging_id": line.product_packaging_id,

nguyenminhchien · 2025-12-04T03:24:39Z

I just made a change in https://github.com/OCA/purchase-workflow/pull/2892
Please pull this to have the latest codebase.

nguyenminhchien · 2025-12-09T07:36:31Z

purchase_compute_order/views/computed_purchase_order_view.xml

-                                    <field name="product_code_inv" readonly="1" />
+                                    <field
+                                        name="product_code_inv"
+                                        string="Supplier Product Code"


Why did you remove readonly="1"?

nguyenminhchien · 2025-12-09T07:38:52Z

purchase_compute_order/views/computed_purchase_order_view.xml

+                                    <field name="incoming_qty" string="Incoming" />
                                    <field
                                        name="displayed_average_consumption"
-                                        readonly="1"


Why did you remove readonly="1"?

nguyenminhchien · 2025-12-09T07:40:20Z

purchase_compute_order/views/computed_purchase_order_view.xml

                                        name="purchase_qty_package"
-                                        attrs="{'readonly':
-                                        [('cpo_state', '!=', 'draft')]}"
+                                        readonly="cpo_state != 'draft'"


readonly="cpo_state != 'draft' or not product_packaging_id"

User needs to choose the packaging first.

nguyenminhchien · 2025-12-09T07:41:09Z

purchase_compute_order/views/computed_purchase_order_view.xml

+                                        readonly="1"
+                                        groups="product.group_stock_packaging"
+                                    />
+                                    <field name="purchase_qty" />


readonly="cpo_state != 'draft' or product_packaging_id"

nguyenminhchien · 2025-12-09T07:53:25Z

purchase_compute_order/models/computed_purchase_order.py

+            "product_name": psi.product_name,
+            "product_price": psi.base_price,
+            "price_policy": psi.price_policy,
+            "package_qty": psi.package_qty or psi.min_qty,


Suggested change

"package_qty": psi.package_qty or psi.min_qty,

"product_packaging_id": psi.product_packaging_id.id,

nguyenminhchien · 2025-12-09T08:24:28Z

purchase_compute_order/models/computed_purchase_order_line.py

+            psi_ids = psi_obj.search(
+                [
+                    ("partner_id", "=", partner_id),
+                    ("product_tmpl_id", "=", product_tmpl_id),


add a domain for packaging id of the cpol if any.

nguyenminhchien · 2025-12-09T08:34:27Z

purchase_compute_order/models/computed_purchase_order_line.py

+                "product_name": cpol.product_name,
+                "product_code": cpol.product_code,
+                "product_uom": cpol.uom_po_id.id,
+                "package_qty": cpol.package_qty_inv,


Suggested change

"package_qty": cpol.package_qty_inv,

"product_packaging_id": cpol.product_packaging_id.id,

It's seem that the button call this action will never be called. But just in case.

nguyenminhchien · 2025-12-09T08:49:12Z

purchase_compute_order/readme/DESCRIPTION.md

+    - the theoretical duration of the stock, based on the precedent figures.
+
+- Unlink the products you don't want to buy anymore to this supplier (this only deletes the product_supplierinfo)
+-  Add new products you want to buy and link them (this creates a product_supplierinfo)


Remove this line since it cannot be added now. Most of the fields are readonly: Supplier product code, product, price,..

nguyenminhchien · 2025-12-09T08:49:37Z

purchase_compute_order/readme/DESCRIPTION.md

+
+- Unlink the products you don't want to buy anymore to this supplier (this only deletes the product_supplierinfo)
+-  Add new products you want to buy and link them (this creates a product_supplierinfo)
+- Modify any information about the products: supplier product_code, supplier product_name, purchase price, package quantity, purchase UoM.


Remove this line, these fields are readonly now.
Btw, check and update this file to adapt with the current behaviors.

nguyenminhchien · 2025-12-09T09:01:41Z

purchase_compute_order/models/computed_purchase_order_line.py

+    )
+    uom_id = fields.Many2one(related="product_id.uom_id")
+    product_code = fields.Char(
+        "Supplier Product Code",


You can see that we have some duplicated fields:

product_code vs product_code_inv

product_name vs product_name_inv

product_price vs product_price_inv

discount vs discount_inv

inv here is the short word of inverse. These *_inv fields were allowed the user to update the values of Product.supplierinfo. But, they're readonly now. Means that we don't need them anymore.

Remove them all.

Change these fields to related fields (NO store):

product_code: psi_id.product_code

product_name: psi_id.product_name

product_price: psi_id.price

discount: psi_id.discount

price_policy: psi_id.price_policy

uom_po_id: psi_id.uom_po_id

nguyenminhchien

Error right after opening a CPO record:

nguyenminhchien · 2025-12-10T08:12:46Z

purchase_compute_order/models/computed_purchase_order_line.py

+            )
+            self.psi_id = valid_psi.id
+
+    @api.depends("purchase_qty_package", "package_qty")


Should not depend on package_qty since it's a related field. This could lead to unexpected update behavior.
Depends on product_packaging_id instead.
Check for other related fields: price_policy, discount,...

nguyenminhchien · 2025-12-10T08:31:04Z

purchase_compute_order/models/computed_purchase_order_line.py

+    @api.depends(
+        "purchase_qty", "psi_id.price", "psi_id.price_policy", "psi_id.discount"
+    )
+    def _compute_subtotal_price(self):


Subtotal is incorrect:

price_policy == "package": subtotal = (Number of package) * Base price (from PSI)

Else: Subtotal = (Qty to purchase) * Base price (from PSI)

Take the Discount into account.

Double check to make sure the PO created from CPO, having the same subtotal then.

nguyenminhchien · 2025-12-10T08:33:42Z

purchase_compute_order/views/computed_purchase_order_view.xml

+                                    />
+                                    <field name="stock_duration" />
+                                    <field
+                                        name="product_packaging_id"


Add context to set the product when adding a new package here.

nguyenminhchien · 2025-12-10T08:51:36Z

purchase_compute_order/models/computed_purchase_order.py

+                line_values = {
+                    "name": line_name,
+                    "product_qty": line.purchase_qty,
+                    "package_qty": line.package_qty,


Suggested change

"package_qty": line.package_qty,

"product_packaging_id": line.product_packaging_id.id,

Krunal and others added 11 commits November 20, 2025 10:06

[MIG] Migration to 12.0: purchase_compute_order

7672718

[UPD] Update purchase_compute_order.pot

4d15b0e

Cleanup dependancy

fa8b3b7

[ADD] Added new feature to sort Computed PO lines (OCA#96)

9644d4f

* [ADD] Added new feature to sort Computed PO lines * [ADD] Added new feauture to see Computed purchase order lines, Improved fr translations

[UPD] Update purchase_compute_order.pot

585d683

[UPD] Update purchase_compute_order.pot

66e9cb1

[IMP] Improved partner form view

6124e1c

[UPD] Update purchase_compute_order.pot

41af705

[ADD] icon.png

Translated using Weblate (French)

9e31af5

Currently translated at 100.0% (178 of 178 strings) Translation: foodcoops-12.0/foodcoops-12.0-purchase_compute_order Translate-URL: https://translate.druidoo.io/projects/foodcoops-12-0/foodcoops-12-0-purchase_compute_order/fr/

[IMP] purchase_compute_order: pre-commit auto fixes

65f7605

P-H-Phuc force-pushed the 18.0-mig-purchase_compute_order branch from b0fd57a to 7317a54 Compare November 24, 2025 09:04

nguyenminhchien suggested changes Nov 27, 2025

View reviewed changes

P-H-Phuc force-pushed the 18.0-mig-purchase_compute_order branch from 7317a54 to 5f89bf6 Compare November 28, 2025 08:00

P-H-Phuc requested a review from nguyenminhchien December 1, 2025 04:15

P-H-Phuc changed the title ~~[18.0[MIG] purchase_compute_order: Migration to 18.0~~ [18.0][MIG] purchase_compute_order: Migration to 18.0 Dec 2, 2025

nguyenminhchien suggested changes Dec 4, 2025

View reviewed changes

P-H-Phuc force-pushed the 18.0-mig-purchase_compute_order branch 2 times, most recently from 38c3b6e to c7a2201 Compare December 8, 2025 08:20

P-H-Phuc requested a review from nguyenminhchien December 8, 2025 08:23

nguyenminhchien suggested changes Dec 9, 2025

View reviewed changes

P-H-Phuc force-pushed the 18.0-mig-purchase_compute_order branch 3 times, most recently from 1241867 to 1176b9e Compare December 10, 2025 07:21

P-H-Phuc requested a review from nguyenminhchien December 10, 2025 07:22

nguyenminhchien suggested changes Dec 10, 2025

View reviewed changes

nguyenminhchien reviewed Dec 10, 2025

View reviewed changes

P-H-Phuc force-pushed the 18.0-mig-purchase_compute_order branch from 1176b9e to 1ec9fbe Compare December 10, 2025 08:27

P-H-Phuc requested a review from nguyenminhchien December 10, 2025 08:53

nguyenminhchien suggested changes Dec 10, 2025

View reviewed changes

[MIG] purchase_compute_order: Migration to 18.0

ead5d8b

P-H-Phuc force-pushed the 18.0-mig-purchase_compute_order branch from 1ec9fbe to ead5d8b Compare December 10, 2025 10:01

P-H-Phuc requested a review from nguyenminhchien December 10, 2025 10:13

	<field name="price_policy" />
	<field name="price_policy" groups="product.group_stock_packaging"/>

	<field name="price_policy" readonly="1" />
	<field name="price_policy" readonly="1" groups="product.group_stock_packaging" />

	"package_qty": line.package_qty,
	"product_packaging_id": line.product_packaging_id,

	"package_qty": psi.package_qty or psi.min_qty,
	"product_packaging_id": psi.product_packaging_id.id,

	"package_qty": cpol.package_qty_inv,
	"product_packaging_id": cpol.product_packaging_id.id,

[18.0][MIG] purchase_compute_order: Migration to 18.0 #2

Are you sure you want to change the base?

[18.0][MIG] purchase_compute_order: Migration to 18.0 #2

Uh oh!

Conversation

P-H-Phuc commented Nov 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nguyenminhchien left a comment

Choose a reason for hiding this comment

Uh oh!

nguyenminhchien left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nguyenminhchien left a comment

Choose a reason for hiding this comment

Uh oh!

nguyenminhchien left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nguyenminhchien commented Dec 4, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nguyenminhchien left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

P-H-Phuc commented Nov 24, 2025 •

edited

Loading