Add more error macros #577
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wvpm
reviewed
Oct 14, 2025
wvpm
reviewed
Oct 14, 2025
wvpm
reviewed
Oct 14, 2025
wvpm
previously requested changes
Oct 14, 2025
Contributor
wvpm
left a comment
wvpm
left a comment
There was a problem hiding this comment.
Don't use macros to log 1 message and return.
Require context for log messages.
Member
Author
|
Logger::error already gives context, we don't need to add anything to that. |
Spartan322
dismissed
wvpm’s stale review
Your review does not understand how these macros work.
wvpm
reviewed
Oct 15, 2025
wvpm
reviewed
Oct 15, 2025
wvpm
reviewed
Oct 15, 2025
wvpm
reviewed
Oct 15, 2025
wvpm
previously requested changes
Oct 15, 2025
Contributor
wvpm
left a comment
wvpm
left a comment
There was a problem hiding this comment.
Don't use macros to log 1 message and return.
Require context for log messages.
"Index " _OV_STR(m_index) " = ", m_index
Spartan322
force-pushed
the
add/more-error-macros
branch
from
9f40b50 to
4dfb83a
Compare
Hop311
previously approved these changes
Oct 17, 2025
Contributor
Hop311
left a comment
Hop311
left a comment
There was a problem hiding this comment.
Some stuff could be slightly cleaned up but overall I welcome this, I can help switch stuff to using it once it's merged (especially places we could benefit from unlikely)
Fix error macro names in comments
Spartan322
force-pushed
the
add/more-error-macros
branch
from
4dfb83a to
40a5409
Compare
Hop311
approved these changes
Oct 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.