Skip to content

Conversation

@Kyle-Ye
Copy link
Collaborator

@Kyle-Ye Kyle-Ye commented Jan 1, 2026

No description provided.

@augmentcode
Copy link

augmentcode bot commented Jan 1, 2026

🤖 Augment PR Summary

Summary: Introduces a reusable geometry-observer container for the view graph, intended to track size changes for specific layout proposals.

Changes:

  • Added ViewGraphGeometryObservers and ViewGraphGeometryMeasurer to measure sizes by proposal and track pending/stable transitions.
  • Implemented a small state machine (Storage) to detect changes and surface “pending” notifications.
  • Exposed ViewGraph.sizeThatFitsObservers as a package property and added SizeThatFitsMeasurer (+ SizeThatFitsObservers typealias).
  • Relaxed access on layoutComputer and rootViewInsets to support the new measurer.
  • Added tests covering observer add/remove exclusivity behavior (with a placeholder callback test).

Technical Notes: The new API is generic over a measurer, enabling reuse for other geometry signals beyond sizeThatFits.

🤖 Was this summary useful? React with 👍 or 👎

Copy link

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 3 suggestions posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

@codecov
Copy link

codecov bot commented Jan 1, 2026

Codecov Report

❌ Patch coverage is 47.36842% with 40 lines in your changes missing coverage. Please review.
✅ Project coverage is 28.76%. Comparing base (b744311) to head (9664d79).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...UICore/View/Graph/ViewGraphGeometryObservers.swift 54.09% 28 Missing ⚠️
Sources/OpenSwiftUICore/View/Graph/ViewGraph.swift 20.00% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #695      +/-   ##
==========================================
+ Coverage   28.75%   28.76%   +0.01%     
==========================================
  Files         588      589       +1     
  Lines       35701    35775      +74     
==========================================
+ Hits        10266    10291      +25     
- Misses      25435    25484      +49     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Kyle-Ye Kyle-Ye force-pushed the feature/ViewGraphGeometryObservers branch from 191f256 to 9664d79 Compare January 1, 2026 15:18
@Kyle-Ye Kyle-Ye merged commit d92457e into main Jan 1, 2026
7 of 8 checks passed
@Kyle-Ye Kyle-Ye deleted the feature/ViewGraphGeometryObservers branch January 1, 2026 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants