Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some assertions were wrong and MockModel init didn't set some variables causing wrong branches. Also swapped dims to prevent D_HEAD == NUM_HEADS. Possibly fixes #1968
Test failing is expected as mqa doesn't support knorm. This should also use _merge_time_and_head_dims because kv_heads can be 1 when it shouldn't be merged (tp/t5 relative pos)
CTranslate2/src/layers/attention.cc
Lines 371 to 374 in 91d46ec