Add ion mobility support via float data arrays and mobilogram wrapper #21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for ion mobility dimension in float data arrays and mobilogram support
Implementation Complete ✓
Successfully implemented comprehensive support for ion mobility data in openms-python:
Features Implemented
Float Data Arrays in Py_MSSpectrum ✓
float_data_arraysproperty for direct access to float data arraysion_mobilityproperty for convenient ion mobility access/manipulationdrift_timeproperty for spectrum-level drift timeto_dataframe()to include float arrays as columnsfrom_dataframe()to create float arrays from DataFrame columnsPy_Mobilogram Class ✓
drift_time,intensity,mz,nametotal_ion_current,base_peak_drift_time,base_peak_intensityto_dataframe(),from_dataframe(),from_arrays()Testing ✓
Documentation ✓
Code Quality ✓
Files Modified
openms_python/py_msspectrum.py- Added float data array and ion mobility supportopenms_python/py_mobilogram.py- New file with Py_Mobilogram classopenms_python/__init__.py- Exported new Py_Mobilogram classtests/test_py_msspectrum.py- Added 8 new tests for ion mobility featurestests/test_py_mobilogram.py- New test file with 10 tests for mobilogramsREADME.md- Added documentation and examplesVerification
Ready for Review
This PR is complete and ready for review. All requirements from the problem statement have been implemented with comprehensive testing and documentation.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.