Skip to content

Veda Promotion Eligibility Color Coding Changes #4638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Charitha2009 wants to merge 1 commit into
base: development
Choose a base branch
from
Open

Veda Promotion Eligibility Color Coding Changes #4638

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/components/HGNPRDashboard/PromotionEligibility.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,12 @@ function PromotionEligibility({ currentUser }) {
}) => (
<tr key={id}>
<td data-label="Reviewer Name">{reviewerName}</td>
<td data-label="Weekly Requirements">{weeklyRequirementsMet ? '✔️' : '❌'}</td>
<td
data-label="Weekly Requirements"
className={weeklyRequirementsMet ? 'status-met' : 'status-not-met'}
>
{weeklyRequirementsMet ? '✓ Has Met' : '✗ Has not Met'}
</td>
<td data-label="Required PRs">{requiredPRs}</td>
<td data-label="Total Reviews Done">{totalReviews}</td>
<td data-label="Remaining Weeks">{remainingWeeks}</td>
Expand Down
29 changes: 29 additions & 0 deletions src/components/HGNPRDashboard/PromotionEligibility.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,26 @@
color: white;
}

/* Status colors for Weekly Requirements */
.promo-table td.status-met {
color: #22863a;
font-weight: 500;
}

.promo-table td.status-not-met {
color: #cb2431;
font-weight: 500;
}

/* Dark mode status colors - higher specificity to override td color */
.promo-table-container.dark .promo-table td.status-met {
color: #53d06e !important;
}

.promo-table-container.dark .promo-table td.status-not-met {
color: #fa7970 !important;
}

/* mobile */

@media screen and (max-width: 768px) {
Expand Down Expand Up @@ -221,4 +241,13 @@
background-color: transparent;
color: #f0f0f0;
}

/* Mobile dark mode status colors */
.promo-table-container.dark .promo-table td.status-met {
color: #53d06e !important;
}

.promo-table-container.dark .promo-table td.status-not-met {
color: #fa7970 !important;
}
}
14 changes: 8 additions & 6 deletions src/components/QuestionnaireDashboard/PromotionTable.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,11 +93,12 @@
color: #586069;
}

.statusMet {
/* Status colors for Weekly Requirements */
.promotionTable td.statusMet {
color: #22863a;
}

.statusNotMet {
.promotionTable td.statusNotMet {
color: #cb2431;
}

Expand Down Expand Up @@ -180,12 +181,13 @@
color: #f0f0f0;
}

[data-theme="dark"] .statusMet {
color: #53d06e;
/* Dark mode status colors - higher specificity to override td color */
[data-theme="dark"] .promotionTable td.statusMet {
color: #53d06e !important;
}

[data-theme="dark"] .statusNotMet {
color: #fa7970;
[data-theme="dark"] .promotionTable td.statusNotMet {
color: #fa7970 !important;
}

@media (max-width: 768px) {
Expand Down
Loading