feat: Add TODO comment for timezone standardization in EventCard #4633
+288
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added comment indicating where timezone conversion will be implemented - This is the initial step for standardizing event time display based on user timezone
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
pavanputti
added
the
do not review
pavanputti
force-pushed
the
feature/standardize-event-timezone-display
branch
from
eff1ef7 to
f67d61e
Compare
Phase 2 - Setup & Preparation: - Created timezoneUtils.js file with skeleton functions - Added placeholder functions: getUserTimezone, convertToUserTimezone, getTimezoneAbbreviation, formatDateTimeWithTimezone - Added TODO comments explaining what each function will do - No implementation yet - structure only
Phase 3 improvements: - Implemented getUserTimezone() function using Intl.DateTimeFormat API - Added exploration functions for testing date-fns-tz vs moment-timezone approaches - Added comments in EventCard showing where timezone conversion will be implemented - Added import comment (commented out) for future use - Explored conversion options: moment-timezone (already in use) vs date-fns-tz (available) - No full implementation yet - exploration phase only
Phase 4 improvements: - Added moment-timezone import for testing conversion approaches - Enhanced getUserTimezone() with validation and error handling - Implemented test functions for both moment-timezone and date-fns-tz approaches - Added bug fixes: null checks, validation, error handling - Tested timezone detection across browsers (Chrome, Firefox, Safari, Edge) - Documented testing results: decided to use moment-timezone for consistency - Fixed issues found during testing: invalid date handling, null checks - No full implementation yet - testing phase only
- Implemented complete timezone conversion using moment-timezone - Added formatDateTimeWithTimezone function with timezone abbreviation - Updated EventCard to use timezone utilities for time display - Added location placeholder 'Location TBD' for empty locations - Added error handling for date formatting - Removed exploration functions from timezoneUtils - Event times now display in user's local timezone with abbreviation (e.g., '2:00 PM PST')
|
- Updated timezoneUtils to use current date for timezone abbreviation (ensures all events show same PST/PDT) - Fixed CPDashboard to use timezone utilities for consistent time display - Improved event card alignment for date, time, and location with icons - Fixed EventCard import path - All events now show consistent timezone abbreviation across all cards
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include the exact bug/functionality description and a summary of the changes/ related issues. Please also include any other relevant motivation and context:
Fixes # (bug list priority high/medium/low x.y.z)
Or Implements # (WBS)
Related PRS (if any):
This frontend PR is related to the #XXX backend PR.
To test this backend PR you need to checkout the #XXX frontend PR.
…
Main changes explained:
…
How to test:
npm installand...to run this PR locallyScreenshots or videos of changes:
Note:
Include the information the reviewers need to know.