Skip to content

Conversation

@Prasad-JB
Copy link

  • Updated workflow to use actions/checkout@v4.

  • Confirmed gaurav-nelson/github-action-markdown-link-check@v1.0.15 is the latest stable release.

  • No source code changes required; this ensures GitHub Actions run with maintained dependencies.

Addresses issue #71 by keeping the workflow up-to-date and reducing reliance on deprecated transitive dependencies.

@tghosth tghosth marked this pull request as draft September 22, 2025 09:07
@tghosth
Copy link
Collaborator

tghosth commented Sep 22, 2025

Hi @Prasad-JB, can you confirm which issue this is addressing, I think you have the wrong reference in the text.

Have you tested that the actions work on your branch?

@Prasad-JB
Copy link
Author

Prasad-JB commented Sep 29, 2025

Hi @tghosth,
Thanks for the review

1. The PR updates the URL Checker workflow to use actions/checkout@v4 and gaurav-nelson/github-action-markdown-link-check@v1.0.15, which is the latest stable release.
2. This addresses issue #71 (keeping workflows up-to-date and reducing reliance on deprecated dependencies). I realize the current text might have been unclear about the issue reference—thanks for pointing that out!
3. I have tested the workflow on my branch, and all required checks pass.

I can update the PR description to make the issue reference explicit and remove any confusion.

@Prasad-JB Prasad-JB marked this pull request as ready for review September 29, 2025 18:43
@tghosth tghosth marked this pull request as draft October 13, 2025 10:59
@tghosth
Copy link
Collaborator

tghosth commented Oct 13, 2025

@Prasad-JB issue #71 has nothing to do with github workflows...

@Prasad-JB
Copy link
Author

Hey @tghosth, you’re right, issue #71 isn’t related to workflows.

This PR just updates the URL Checker workflow to use actions/checkout@v4 and the latest gaurav-nelson/github-action-markdown-link-check@v1.0.15. No functional changes, just keeping things up to date.

I’ve tested it on my branch and everything runs fine. I’ll remove the wrong issue reference from the description to avoid confusion.

@tghosth
Copy link
Collaborator

tghosth commented Oct 16, 2025

So I just don't understand the rationale here. Can you prepare a more detailed explanation of why I would want to do this, especially since with one you are making it more specific and the other you are making it more general so I don't understand the logic.

@Prasad-JB
Copy link
Author

Hey @tghosth, totally understand the confusion, let me clarify a bit.
The main goal here isn’t to change how the workflow behaves, but to keep it aligned with the latest supported GitHub Actions versions:

actions/checkout@v4 moves us from Node 16 to Node 20, since Node 16 has reached EOL. This prevents future CI warnings or compatibility issues.

gaurav-nelson/github-action-markdown-link-check@v1.0.15 is just the latest stable release with updated dependencies and small internal fixes, no logic changes.

So while one update might look like it’s making things “more specific” and the other “more general,” the intent is simply to make sure we’re using maintained and supported versions going forward.
It’s mainly a small maintenance/housekeeping PR to keep the repo future-proof, not changing any workflow logic or behavior.

@tghosth
Copy link
Collaborator

tghosth commented Oct 19, 2025

The main goal here isn’t to change how the workflow behaves, but to keep it aligned with the latest supported GitHub Actions versions

I understand this.

So while one update might look like it’s making things “more specific” and the other “more general,” the intent is simply to make sure we’re using maintained and supported versions going forward.

Regardless of the intent, I still don't think you have provided a clear enough explanation of the logic in making one “more specific” and the other “more general,”

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants