[IMP] sign_oca: Add error handling for corrupted PDFs #147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi @etobella, |
YoussefEttamimi
force-pushed
the
fix-corrupted-pdf-handling
branch
from
710f7e2 to
34f01d5
Compare
- Use strict=False to handle PDFs with minor format issues - Add try-catch for PDF read operations with clear error messages - Add try-catch for PDF write operations with helpful user feedback - Prevent crashes when processing PDFs with encoding issues - Use 'raise from' for proper exception chaining This improvement handles PDFs that contain encoding problems or illegal characters that would normally cause PyPDF2 to fail with PdfReadError, providing a more robust document signing experience.
YoussefEttamimi
force-pushed
the
fix-corrupted-pdf-handling
branch
from
34f01d5 to
42005df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improvement handles PDFs that contain encoding problems or illegal characters that would normally cause PyPDF2 to fail with PdfReadError, providing a more robust document signing experience.