[17.0][FIX] base_report_to_printer: neutralization scripts #434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vicent-S73
changed the title
Vicent-S73
force-pushed
the
17.0-fix-base_report_to_printer-neutralization
branch
from
5b3d0f4 to
07972c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even with odoo neutralize script executed reports where still being sent to printers.
On one side the search for users behaviours finds them even though the printers where deactivated, thus the need to a add an active field to this model and set it to false in the script.
On the other side the general printer configured in a report needs to be cleaned or it will otherwise be found and used for printing.
The second commits is for:
- The tests are designed to check the API response, but the problem is that two requests are made within a short time interval. A mock would be appropriate if what was being checked was not the response from api.labelary.