Skip to content

Conversation

@ecino
Copy link

@ecino ecino commented Sep 17, 2024

This pull request refactors the printer tray handling in the base_report_to_printer module to support separate input and output trays, improving flexibility.

Model and Field Refactoring

  • Split the generic printing.tray model into two distinct models: printing.tray.input and printing.tray.output, and updated all related fields in ir.actions.report, printing.printer, printing.report.xml.action, and res.users to use these new models for input and output trays.
  • Updated onchange and default behaviour methods to reset and return values for both input and output trays, ensuring correct handling when printer or tray selections change.

Printer Synchronization and Options

  • Modified the printer update logic to separately synchronize input and output trays from CUPS, and added new methods for setting printer options for both tray types.

Security and Access Control

  • Updated security rules to grant appropriate access to the new input and output tray models, including separate permissions for users and managers.

Tests and Backwards Compatibility

  • Refactored tests to use the new input/output tray fields and models, ensuring all behaviour checks are updated and remain valid.

Miscellaneous

  • Updated the module version to 17.0.1.1.2 to reflect these changes.

@ecino ecino changed the title [IMP] base_report_to_printer : add output_tray [17.0][IMP] base_report_to_printer : add output_tray Sep 17, 2024
@ecino ecino force-pushed the 17.0-printer-output-tray branch from 7c00129 to 283ccc7 Compare November 25, 2024 12:00
@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Mar 30, 2025
@ecino ecino marked this pull request as draft March 31, 2025 06:28
@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Apr 6, 2025
@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Aug 10, 2025
@ecino ecino force-pushed the 17.0-printer-output-tray branch from 283ccc7 to 84b8d5f Compare August 12, 2025 06:57
@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Aug 17, 2025
@ecino ecino force-pushed the 17.0-printer-output-tray branch 2 times, most recently from eb05b6f to 0d07f92 Compare September 18, 2025 13:50
- Enables selection of printer output tray
@ecino ecino force-pushed the 17.0-printer-output-tray branch from 0d07f92 to 682f255 Compare September 18, 2025 13:54
@ecino ecino marked this pull request as ready for review September 18, 2025 13:57
@ecino
Copy link
Author

ecino commented Sep 18, 2025

Hello, here is a nice addition ready for review!

@ecino
Copy link
Author

ecino commented Sep 25, 2025

@chienandalu @pedrobaeza Maybe you would like to give a review?

@pedrobaeza pedrobaeza added this to the 17.0 milestone Sep 25, 2025
@pedrobaeza
Copy link
Member

These are deep changes that require migration scripts to adapt existing models and fields.

@ecino
Copy link
Author

ecino commented Sep 25, 2025

@pedrobaeza Added migration scripts.

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In a code review, it sounds OK

@ecino
Copy link
Author

ecino commented Oct 8, 2025

Hi @sergio-teruel,

Just a friendly ping on this PR when you get a chance. Let me know if you have any questions or need more context!

Thanks!

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza
Copy link
Member

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-365-by-pedrobaeza-bump-minor, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Oct 31, 2025
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Contributor

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 17.0-ocabot-merge-pr-365-by-pedrobaeza-bump-minor.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@ecino
Copy link
Author

ecino commented Nov 3, 2025

@pedrobaeza There is a test failure in module printer_zpl2 that I didn't see previously, is it something coming from my changes I need to fix or not related? Let me know if you are expecting something from me.

@pedrobaeza
Copy link
Member

Well, I can't merge it being red, so I can't go any further.

@ecino ecino force-pushed the 17.0-printer-output-tray branch from d428464 to 89c822a Compare November 3, 2025 13:15
@ecino
Copy link
Author

ecino commented Nov 3, 2025

@pedrobaeza My branch doesn't produce this error. I don't know how to resolve the issue.

@pedrobaeza
Copy link
Member

It seems to be intermittent. Let's try again:

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 17.0-ocabot-merge-pr-365-by-pedrobaeza-bump-minor, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Nov 3, 2025
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Contributor

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 17.0-ocabot-merge-pr-365-by-pedrobaeza-bump-minor.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants