[18.0][MIG] website_sale_product_pack: Migration to 18.0 #194

ALopez-Adhoc · 2024-12-06T20:14:48Z

No description provided.

matiasperalta1

LGTM

website_sale_product_pack/__init__.py

website_sale_product_pack/controllers/__init__.py

website_sale_product_pack/controllers/main.py

website_sale_product_pack/controllers/variant.py

website_sale_product_pack/models/product_template.py

augusto-weiss · 2025-01-20T14:39:05Z

Hi @ALopez-Adhoc i added some review... also edit the commit name please to [18.0][MIG] thanks a lot

ALopez-Adhoc · 2025-01-20T18:42:17Z

@augusto-weiss Thanks for the review. The changes has been applied. You can review them again if you will

Compatibility module between sale_product_pack and website_sale TT30385

Done for e-commerce compatibility purposes, althoug it's more performant indeed.

Create and select a specific pricelist for avoiding problems in integrated environments where the default pricelist currency has been changed.

When the cart is confirmed, a price recalculation is triggered for every order line. This is wrong for detailed totalized packs, which lines should be at 0. TT38186

…ts using packs

website_sale_product_pack/models/website.py

website_sale_product_pack/models/__init__.py

augusto-weiss · 2025-01-24T15:12:37Z

LGTM Thanks @ALopez-Adhoc

OCA-git-bot · 2025-01-24T16:00:02Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

matiasperalta1 · 2025-01-28T19:55:23Z

@pedrobaeza Is it ready to merge?

nicolascol · 2025-01-31T14:27:24Z

Hi @rousseldenis
Could you merge?
THZ

github-actions · 2025-06-01T12:37:40Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

mmrondon · 2025-07-02T19:59:00Z

hello
I was wondering if there are any plans to review or merge it soon
Thanks in advance!

nicolascol · 2025-08-08T15:25:12Z

Hi! Could you merge please?
@pedrobaeza @rousseldenis

augusto-weiss · 2025-08-12T14:54:09Z

@mmrondon Hi, could you test it ?

rousseldenis · 2025-10-06T07:51:49Z

/ocabot migration website_sale_product_pack

rousseldenis · 2025-10-06T07:56:15Z

website_sale_product_pack/tests/test_website_sale_product_pack.py

+
+@tagged("post_install", "-at_install")
+class WebsiteSaleHttpCase(HttpCase):
+    def setUp(self):


Change this to classmethod

Done! @rousseldenis THZ

Copilot

Pull Request Overview

This PR migrates the website_sale_product_pack module from version 17.0 to 18.0, introducing compatibility for product packs with e-commerce functionality.

Adds comprehensive website sale integration for product packs including cart handling, pricing, and display logic
Introduces validation constraints to ensure pack components are properly published
Provides complete test coverage with HTTP tours for different pack types

Reviewed Changes

Copilot reviewed 19 out of 20 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
`__manifest__.py`	Module definition with dependencies and version set to 18.0.1.0.0
`views/templates.xml`	Website templates for cart, checkout, and product display modifications
`models/`	Core business logic for sale orders, product templates, and validation
`tests/`	Test framework with HTTP case tests and JavaScript tours
`static/`	JavaScript tour definitions for e-commerce testing
`i18n/`	Translation files including Italian locale
Documentation	README and description files for module documentation

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-10-07T14:03:31Z

website_sale_product_pack/views/templates.xml

+        <xpath expr="//input[hasclass('js_quantity')]/.." position="attributes">
+            <attribute name="t-if">not line.pack_parent_line_id</attribute>
+        </xpath>
+        <!-- We don't wan't to allow to add extra components. It all must follow the main pack -->


Corrected spelling of 'wan't' to 'want'

Suggested change

Copilot · 2025-10-07T14:03:32Z

website_sale_product_pack/tests/test_website_sale_product_pack.py

+        self.assertEqual(line.price_subtotal, 2662.5)
+        self.assertEqual(self._get_component_prices_sum(self.product_pnd), 2662.5)
+
+    def test__check_to_add_pack_component_pusblished(self):


Corrected spelling of 'pusblished' to 'published'

Suggested change

def test__check_to_add_pack_component_pusblished(self):

def test__check_to_add_pack_component_published(self):

Copilot · 2025-10-07T14:03:32Z

website_sale_product_pack/models/product_template.py

+                        "You can't unpublished products (%(unpublished_products)s) to a"
+                        "published pack (%(pack_name)s)"


The word 'unpublished' should be 'unpublish' as a verb in this context

Copilot · 2025-10-07T14:03:32Z

website_sale_product_pack/models/product_template.py

+                        "You can't unpublished product (%(product_name)s) for a"
+                        "published pack parents (%(pack_parents)s)"


The word 'unpublished' should be 'unpublish' as a verb in this context

Copilot · 2025-10-07T14:03:32Z

website_sale_product_pack/models/product_product.py

+                    _(
+                        "You can't add unpublished products "
+                        "(%(unpublished_products)s)"
+                        "to a published pack (%(pack_name)s)"


Missing space between 'products' and the opening parenthesis

Suggested change

"to a published pack (%(pack_name)s)"

" to a published pack (%(pack_name)s)"

XenoMannens · 2025-11-13T10:41:43Z

@ALopez-Adhoc Any ETA on this migration since we have a customer that wants to use this module.

Thanks in advance

ALopez-Adhoc force-pushed the 18.0-mig-website_sale_product_pack branch 4 times, most recently from f8dd1ef to cc7e0f7 Compare December 26, 2024 19:41

This was referenced Dec 27, 2024

[DUMMY] website_sale_product_pack: Migration to 18.0 #200

Closed

Migration to version 18.0 #185

Open

matiasperalta1 force-pushed the 18.0-mig-website_sale_product_pack branch from cc7e0f7 to b070ee4 Compare January 17, 2025 18:30

matiasperalta1 approved these changes Jan 17, 2025

View reviewed changes

augusto-weiss suggested changes Jan 20, 2025

View reviewed changes

ALopez-Adhoc force-pushed the 18.0-mig-website_sale_product_pack branch from b070ee4 to 59167c4 Compare January 20, 2025 18:30

ALopez-Adhoc changed the title ~~[18.0][MIG} website_sale_product_pack: Migration to 18.0~~ [18.0][MIG] website_sale_product_pack: Migration to 18.0 Jan 20, 2025

ALopez-Adhoc force-pushed the 18.0-mig-website_sale_product_pack branch 4 times, most recently from fc791c8 to d95f90a Compare January 22, 2025 12:03

chienandalu and others added 13 commits January 23, 2025 10:10

[ADD] website_sale_product_pack: New module

b913a73

Compatibility module between sale_product_pack and website_sale TT30385

[FIX] stock_product_pack: get already computed values if existing

cc9f302

Done for e-commerce compatibility purposes, althoug it's more performant indeed.

[UPD] Update website_sale_product_pack.pot

3d8f979

[UPD] README.rst

9b1a5cb

[ADD] icon.png

8eb48bf

[FIX] website_sale_product_pack: Resilient tests

2cf9cf9

Create and select a specific pricelist for avoiding problems in integrated environments where the default pricelist currency has been changed.

Set portal user pricelist

af59b88

[FIX] website_sale_product_pack: detailed totalized packs

9e9b14e

When the cart is confirmed, a price recalculation is triggered for every order line. This is wrong for detailed totalized packs, which lines should be at 0. TT38186

website_sale_product_pack 13.0.1.0.1

72d0710

website_sale_product_pack 13.0.1.0.2

d753053

[IMP] website_sale_product_pack: Published and unpublished for produc…

a80122f

…ts using packs

[UPD] Update website_sale_product_pack.pot

91e1d17

[UPD] README.rst

fb2417d

[IMP] website_sale_product_pack: pre-commit execution

7636f2c

ALopez-Adhoc force-pushed the 18.0-mig-website_sale_product_pack branch from d95f90a to 1db6641 Compare January 23, 2025 13:19

augusto-weiss suggested changes Jan 23, 2025

View reviewed changes

website_sale_product_pack/models/website.py Outdated Show resolved Hide resolved

website_sale_product_pack/models/__init__.py Outdated Show resolved Hide resolved

ALopez-Adhoc force-pushed the 18.0-mig-website_sale_product_pack branch from 1db6641 to ba06b65 Compare January 23, 2025 19:28

augusto-weiss approved these changes Jan 24, 2025

View reviewed changes

OCA-git-bot added the approved label Jan 24, 2025

OCA-git-bot added the ready to merge label Jan 24, 2025

github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jun 1, 2025

lef-adhoc mentioned this pull request Jul 4, 2025

[IMP] website_sale_product_pack: apply taxes to pack prices in website #213

Closed

github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jul 6, 2025

lef-adhoc force-pushed the 18.0-mig-website_sale_product_pack branch from ba06b65 to 031a47f Compare July 17, 2025 19:32

lef-adhoc force-pushed the 18.0-mig-website_sale_product_pack branch from 031a47f to 58d3bad Compare August 7, 2025 17:19

OCA-git-bot added this to the 18.0 milestone Oct 6, 2025

rousseldenis reviewed Oct 6, 2025

View reviewed changes

Copilot AI review requested due to automatic review settings October 7, 2025 14:02

augusto-weiss force-pushed the 18.0-mig-website_sale_product_pack branch from 58d3bad to 39bdcaa Compare October 7, 2025 14:02

Copilot AI reviewed Oct 7, 2025

View reviewed changes

qtheuret approved these changes Oct 20, 2025

View reviewed changes

[MIG] website_sale_product_pack: Migration to 18.0

8a13b5c

lef-adhoc force-pushed the 18.0-mig-website_sale_product_pack branch from 39bdcaa to 8a13b5c Compare December 13, 2025 16:56

	<!-- We don't wan't to allow to add extra components. It all must follow the main pack -->
	<!-- We don't want to allow to add extra components. It all must follow the main pack -->

	def test__check_to_add_pack_component_pusblished(self):
	def test__check_to_add_pack_component_published(self):

		"You can't unpublished products (%(unpublished_products)s) to a"
		"published pack (%(pack_name)s)"

		"You can't unpublished product (%(product_name)s) for a"
		"published pack parents (%(pack_parents)s)"

	"to a published pack (%(pack_name)s)"
	" to a published pack (%(pack_name)s)"

Uh oh!

[18.0][MIG] website_sale_product_pack: Migration to 18.0 #194

Are you sure you want to change the base?

[18.0][MIG] website_sale_product_pack: Migration to 18.0 #194

Uh oh!

Conversation

ALopez-Adhoc commented Dec 6, 2024

Uh oh!

matiasperalta1 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

augusto-weiss commented Jan 20, 2025

Uh oh!

ALopez-Adhoc commented Jan 20, 2025

Uh oh!

Uh oh!

Uh oh!

augusto-weiss commented Jan 24, 2025

Uh oh!

OCA-git-bot commented Jan 24, 2025

Uh oh!

matiasperalta1 commented Jan 28, 2025

Uh oh!

nicolascol commented Jan 31, 2025

Uh oh!

github-actions bot commented Jun 1, 2025

Uh oh!

mmrondon commented Jul 2, 2025

Uh oh!

nicolascol commented Aug 8, 2025

Uh oh!

augusto-weiss commented Aug 12, 2025

Uh oh!

rousseldenis commented Oct 6, 2025

Uh oh!

rousseldenis Oct 6, 2025

Choose a reason for hiding this comment

Uh oh!

augusto-weiss Oct 7, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Oct 7, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 7, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 7, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 7, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 7, 2025

Choose a reason for hiding this comment

Uh oh!

XenoMannens commented Nov 13, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

17 participants