[MIG] [18.0] oca_custom #71
Conversation
…IMP] remove warning when analysing Odoo modules manifest, if docutils raise warning
* [FIX] make the github page always visible So the github_login field can be set manually.
Kiplangatdan
force-pushed
the
18.0-mig-oca-custom
branch
from
c29832c to
d855dc3
Compare
gfcapalbo
left a comment
gfcapalbo
left a comment
There was a problem hiding this comment.
Approved, minimal functionality, but CI is green and all looks good for v18.
needed for:
website_oca_integrator
website_oca_psc_team
these two modules are independent, so this module is needed to support them
MIGRATION NOTE: both these modules should have a dependency on this, but they do not. this is a big problem in the structure.
Probably this is taken care of by a meta-module (oca_all) these two modules are last on the dependency list, but i think we should add correct dependencies on the modules.
A problem, but not regarding this MR. Approved.
| "website": "https://github.com/OCA/oca-custom", | ||
| "author": "GRAP, Akretion, Odoo Community Association (OCA)", | ||
| "license": "AGPL-3", | ||
| "depends": ["github_connector"], |
There was a problem hiding this comment.
| class ResPartner(models.Model): | ||
| _inherit = "res.partner" | ||
|
|
||
| github_name = fields.Char(readonly=False) |
There was a problem hiding this comment.
will be used in Website_oca_integrator, wich has still not been migrated. approved.
I see this field used in:
website_oca_integrator
website_oca_psc_team
wich are independent, so even if this module is very small, approved.
| <record id="res_partner_github_visible" model="ir.ui.view"> | ||
| <field name="name">res.partner.github.visible.form</field> | ||
| <field name="model">res.partner</field> | ||
| <field name="inherit_id" ref="github_connector.view_res_partner_form" /> |
There was a problem hiding this comment.
9 participants
No description provided.