[18.0][FIX] mail_show_follower: handle case where record no longer ex… #133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi @yajo, |
Contributor
|
On my way to merge this fine PR! |
Contributor
|
Congratulations, your PR was merged at 9554f2f. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ists
In the case where the original record from the mail has been deleted, attempting to access any value on it raises:
MissingError: Record does not exist or has been deleted
As a simple solution, this fix skips the module's functionality when the record no longer exists. A more complete solution would be to personalize the message body somewhere upstream, however that would require more changes in the way the module is structured. As of now, this fix seems sufficient for exceptional cases.