[18.0][FIX] helpdesk_mgmt_sla: use _get_resource_calendar() with fallback for SLA calculations #885
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, SLA computations (
_compute_sla_data,_compute_deadline,_stage_recompute) access the calendar directly viaticket_id.team_id.resource_calendar_id. This approach causes errors when:These situations lead to singleton or NoneType errors, causing SLA computation to crash.
Screencast from 2025-11-17 16-09-08.webm
Introduce
_get_resource_calendar()to safely retrieve a calendar for SLA computations: