Skip to content

[FIX] Surround setting view added fields by more standard markup #1363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fcayre wants to merge 3 commits into
base: 16.0
Choose a base branch
from
Open

[FIX] Surround setting view added fields by more standard markup #1363

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4cf0e01
[FIX] Surround setting view added fields by more standard markup
fcayre Dec 18, 2025
2d58f9b
[IMP] Put all contract_forecast setting fields into a single o_settin…
fcayre Dec 19, 2025
9cb2cf1
[IMP] Improve xpath that adds the contract_forecast setting fields af…
fcayre Dec 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 24 additions & 13 deletions contract_forecast/views/res_config_settings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
<field name="inherit_id" ref="contract.res_config_settings_form_view" />
<field name="arch" type="xml">
<xpath
expr="//field[@name='create_new_line_at_contract_line_renew']/parent::div/parent::div/parent::div"
expr="//field[@name='create_new_line_at_contract_line_renew']/ancestor::div[hasclass('o_settings_container')]"
position="after"
>
<div class="row mt16 o_settings_container">
Expand All @@ -20,18 +20,29 @@
<label for="enable_contract_forecast" />
</div>
</div>
</div>
<div
class="row mt16 o_settings_container"
attrs="{'invisible': [('enable_contract_forecast', '=', False)]}"
>
<label
for="contract_forecast_interval"
string="Forecast Interval"
class="oe_inline"
/>
<field name="contract_forecast_interval" class="oe_inline" />
<field name="contract_forecast_rule_type" class="oe_inline" />
<div
class="col-12 col-lg-6 o_setting_box"
attrs="{'invisible': [('enable_contract_forecast', '=', False)]}"
>
<div class="o_setting_left_pane" />
<div class="o_setting_right_pane">
<label
for="contract_forecast_interval"
string="Forecast Interval"
class="oe_inline"
/>
<div>
<field
name="contract_forecast_interval"
class="oe_inline"
/>
<field
name="contract_forecast_rule_type"
class="oe_inline"
/>
</div>
</div>
</div>
</div>
</xpath>
</field>
Expand Down