[19.0] [MIG] contract: Migration to 19.0 #1312

BhaveshHeliconia · 2025-10-01T09:21:06Z

No description provided.

[FIX] - manual_renew_needed should be visible to all contract users [REF] - add _get_next_invoiced_period method [FIX] - Fix In progress contract filter [REF] - add method to get quantity to invoice the contract line quantity can be in some use cases variable, to simplify the way it is changed we add a new method _get_quantity_to_invoice. [FIX] - Onchange contract line don't reste contract lines [FIX] - Rename _get_invoiced_period to _get_period_to_invoice [ADD] - Add stop_at_date_end to _get_period_to_invoice [FIX] - Remove useless filter [FIX] - don't play onchange date_start for old lines on contract template change [FIX] - Fix stop post message [FIX] - Fix sale_contract_count should count all partner contract [FIX] - set recurring_next_date to False if contract line stoped at last date invoiced [FIX] - Group by next_invoice also considers dates in the past [IMP] - A canceled contract line can't be set to auto-renew [REF] Contract: pep8 [IMP] Contract: update USAGE section of README [IMP]call onchange_is_auto_renew when changing template

[REF] use context_today instead of time in filters [REF] Contract: split from analytic account [REF] Contract Sale Invoicing: split from analytic account [REF] Contract Sale Invoicing: update translations [IMP] - Assert that the predecessor is available for new link at uncancel [RMV] - remove usless changes [RMV] - Remove usless field recurring_invoices after the total isolation between contract model and account analytic one. recurring_invoices which was used to mark analytic account as contract became usless [IMP] - P3 syntax [IMP] - use @openupgrade.migrate() and openupgrade.logged_query [IMP] - drop transient table in migration script

[RMV] - Remove empty file [IMP] - Update no_update cron after migration [IMP] - move contract template recurrence info to line level [FIX] - Fix contract line model description [IMP] - Link contracts to analytic accounts [FIX] - Fix pylint [IMP] - Move chatter and attachments from analytic account to contract [IMP] - Move account_analytic_id to contract line level [IMP] - Improve version check in migration script [IMP] - Move contracts followers from analytic accounts [ADD] - Add mail.activity.mixin to contract.contract model remove data drop from migration scripts [12.0][FIX] - Fix _init_last_date_invoiced fix flake8 [ADD] - Update contributors list

* Remove incorrect oldname attributes. * Add filter on partners for running contracts (+ a support o2m field for that). * Cover more tables in model renaming + cleaner code using a loop. * Don't copy contract lines, but rename table + copy contract records on pre. * Contract code is now populated to "Reference/Description" field in invoice. * Order on new contract model has been restored to the same as old analytic accounts.

Currently translated at 100.0% (211 of 211 strings) Translation: contract-12.0/contract-12.0-contract Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-contract/zh_CN/

…unt to contract

Remove string attribute

Currently translated at 96.2% (204 of 212 strings) Translation: contract-12.0/contract-12.0-contract Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-contract/it/

As v11 takes salesman from linked partner and now the salesman is a field in the contract that is initialized to current user, we need to assign to the recently converted contracts following old logic, or they will have admin as responsible.

Currently translated at 78.8% (167 of 212 strings) Translation: contract-12.0/contract-12.0-contract Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-contract/de/

The lowest model access for contract.contract model is group_account_invoice group. However the addon adds two smart buttons to res.partner view without any security restrictions and without compute_sudo attribute on computed fields. This causes the view to crash when a user without the proper permissions tries to access the res.partner form view. The solution adds groups_id to the partner form views in which the buttons are added, so the only loads when the user has proper permissions. Other way to solve it would be to add compute_sudo attribute to the relevant fields, but this causes an access error when the user clicks on the smart buttons.

Currently translated at 61.3% (130 of 212 strings) Translation: contract-12.0/contract-12.0-contract Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-contract/ca/

Currently translated at 100.0% (212 of 212 strings) Translation: contract-12.0/contract-12.0-contract Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-contract/pt_BR/

Done through `oldname`.

Currently translated at 100.0% (212 of 212 strings) Translation: contract-12.0/contract-12.0-contract Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-contract/zh_CN/

Currently translated at 98.1% (208 of 212 strings) Translation: contract-12.0/contract-12.0-contract Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-contract/nl/

…s + Fix contract report

Currently translated at 99.1% (210 of 212 strings) Translation: contract-12.0/contract-12.0-contract Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-contract/de/

Currently translated at 100.0% (212 of 212 strings) Translation: contract-12.0/contract-12.0-contract Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-contract/es/

…tract partner label + contract company must be the same as the sale order - multi-company record rules on contract line causes performance issue - the label Partner (always False) don't make any sens - When creating a contract from a sale order the company must be the sale order company and not the user company

Don't transfer to contract those analytic accounts with the "Recurring invoicing" flag unchecked.

Currently translated at 21.7% (46 of 212 strings) Translation: contract-12.0/contract-12.0-contract Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-contract/hr/

There were an error in previous query for moving only contracts with the mark checked, but it's also more logic to move them, but remain them disabled.

Currently translated at 22.2% (47 of 212 strings) Translation: contract-12.0/contract-12.0-contract Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-contract/hr/

…emplate Fix this use-case: If the contract journal is not set on the contract template the contract is created without a journal when confirming the sale order

… with duplicated name - Don't execute onchange after invoice creation Using that approach (that is the current one in core) has a lot of side effects and performance bottlenecks. You can read odoo/odoo#40156 for summarizing them. This also improves the handling of the values of payment term an fiscal position for using the partner ones if not set. - Tests with duplicated name So they are not executed at all. Detected by chance looking for a test for the other PR.

pedrobaeza · 2025-11-24T07:29:20Z

Please include #1341

BhaveshHeliconia · 2025-11-25T05:06:21Z

Please include #1341

Done. Thanks!

carlos-lopez-tecnativa · 2025-11-25T11:04:45Z

Please include #1351 and #1345

…ct lines This field is unused in this module, but in the contract_sale_invoicing module it is used to search Sales Orders. However, many times this field goes unnoticed and users set the analytic distribution directly on the lines. After this commit, the field is computed automatically based on the contract lines.

…act lines

BhaveshHeliconia · 2025-11-25T12:36:31Z

Please include #1351 and #1345

Done. Thanks!

victoralmau · 2025-11-28T15:13:47Z

Please, cherry-pick #1352 to commit history (before migration commit).

… does not have access TT59505

BhaveshHeliconia · 2025-12-02T07:39:31Z

Please, cherry-pick #1352 to commit history (before migration commit).

Done. Thanks!

pedrobaeza · 2025-12-09T07:21:31Z

/ocabot migration contract

Please include #1360

On portal, the cancelled lines are not distinguished from running ones, as the next invoice date is still displayed, and the color is the same (on contrary than the backend, that appears greyed). So let's do something similar in portal: - Put the row as grey. - Hide the nexte invoice date on that case. TT59704

bosd

Functional test 👍

pedrobaeza

Thanks, I think we are almost there.

pedrobaeza · 2025-12-31T09:34:40Z

contract/models/contract_template_line.py

-        comodel_name="uom.category",
-        related="product_id.uom_id.category_id",
-        readonly=True,
+    allowed_uom_ids = fields.Binary(


The usual convention is to name this as field_domain, which would be in this case uom_id_domain.

pedrobaeza · 2025-12-31T10:53:22Z

contract/models/contract.py

        )
        if not date_ref:
            date_ref = fields.Date.context_today(self)
        domain = self._get_contracts_to_invoice_domain(date_ref)


In this method, it's better to return a Domain, isn't it?

Yes, correct! I'll update it to return a Domain object instead of a list.

ThomasBinsfeld and others added 30 commits October 1, 2025 13:54

[FIX] Contract to Invoice: take contract vendor instead of partner's

5ce189f

[IMP]pass the payment term to the contract from the partner

9a3522f

Translated using Weblate (Chinese (Simplified))

d2891af

Currently translated at 100.0% (211 of 211 strings) Translation: contract-12.0/contract-12.0-contract Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-contract/zh_CN/

[MIG+FIX] contract: Missing pieces for moving info from analytic acco…

92024f1

…unt to contract

Add commercial_partner_id fields into contract module

4310bd4

Remove string attribute

Translated using Weblate (Italian)

61e7968

Currently translated at 96.2% (204 of 212 strings) Translation: contract-12.0/contract-12.0-contract Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-contract/it/

Translated using Weblate (German)

934528b

Currently translated at 78.8% (167 of 212 strings) Translation: contract-12.0/contract-12.0-contract Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-contract/de/

Translated using Weblate (Catalan)

fc2cc14

Currently translated at 61.3% (130 of 212 strings) Translation: contract-12.0/contract-12.0-contract Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-contract/ca/

Translated using Weblate (Portuguese (Brazil))

7eef57b

Currently translated at 100.0% (212 of 212 strings) Translation: contract-12.0/contract-12.0-contract Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-contract/pt_BR/

[MIG] contract: Missing renaming of invoice link

12cd302

Done through `oldname`.

Translated using Weblate (Chinese (Simplified))

2144cc2

Currently translated at 100.0% (212 of 212 strings) Translation: contract-12.0/contract-12.0-contract Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-contract/zh_CN/

[MIG] contract: Create contract sequence for allowing to create records

15a7608

Translated using Weblate (Dutch)

1c872c3

Currently translated at 98.1% (208 of 212 strings) Translation: contract-12.0/contract-12.0-contract Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-contract/nl/

[IMP+FIX] contract: Add multi-company access rule for contract object…

fe4fd0a

…s + Fix contract report

Translated using Weblate (German)

518bd66

Currently translated at 99.1% (210 of 212 strings) Translation: contract-12.0/contract-12.0-contract Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-contract/de/

Translated using Weblate (Spanish)

3ea5dd1

Currently translated at 100.0% (212 of 212 strings) Translation: contract-12.0/contract-12.0-contract Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-contract/es/

[MIG] contract: No contract on AA without recurring invoices flag

69f3d0a

Don't transfer to contract those analytic accounts with the "Recurring invoicing" flag unchecked.

Translated using Weblate (Croatian)

190f738

Currently translated at 21.7% (46 of 212 strings) Translation: contract-12.0/contract-12.0-contract Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-contract/hr/

[IMP] contract: Fix test crash with other modules

517417c

[MIG][FIX] contract: Move contracts, but disable them

8b575bb

There were an error in previous query for moving only contracts with the mark checked, but it's also more logic to move them, but remain them disabled.

Translated using Weblate (Croatian)

06a3585

Currently translated at 22.2% (47 of 212 strings) Translation: contract-12.0/contract-12.0-contract Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-contract/hr/

[12.0][FIX] - Run onchange contract_type when changing the contract t…

167d0b3

…emplate Fix this use-case: If the contract journal is not set on the contract template the contract is created without a journal when confirming the sale order

BhaveshHeliconia force-pushed the 19.0-mig-contract branch 2 times, most recently from b527c46 to 4e377c2 Compare November 21, 2025 09:51

[18.0][IMP] contract: hook for line is invoiceable

666f4df

BhaveshHeliconia force-pushed the 19.0-mig-contract branch from 4e377c2 to 8cddba3 Compare November 25, 2025 05:01

carlos-lopez-tecnativa added 3 commits November 25, 2025 17:52

[IMP] contract: store additional fields for analysis purposes

118be9d

[IMP] contract: enhance search filters and add a pivot view for contr…

8cb1e26

…act lines

BhaveshHeliconia force-pushed the 19.0-mig-contract branch from 8cddba3 to a77b773 Compare November 25, 2025 12:27

[FIX] contract: Avoid the error when accessing the portal if the user…

f133b55

… does not have access TT59505

BhaveshHeliconia force-pushed the 19.0-mig-contract branch from a77b773 to c11153d Compare December 2, 2025 07:31

pedrobaeza and others added 2 commits December 11, 2025 10:17

[IMP] contract: pre-commit auto fixes

b462945

BhaveshHeliconia force-pushed the 19.0-mig-contract branch from c11153d to c00fcd4 Compare December 11, 2025 04:51

bosd approved these changes Dec 24, 2025

View reviewed changes

BhaveshHeliconia requested a review from pedrobaeza December 27, 2025 04:02

This was referenced Dec 29, 2025

[19.0][MIG] contract_variable_quantity #1364

Open

[19.0][MIG] contract_variable_qty_prorated #1365

Open

[19.0][ADD] contract_invoice_offset #1366

Open

[19.0][MIG] contract_termination #1367

Open

pedrobaeza reviewed Dec 31, 2025

View reviewed changes

[MIG] contract: Migration to 19.0

974db1c

BhaveshHeliconia force-pushed the 19.0-mig-contract branch from c00fcd4 to 974db1c Compare January 2, 2026 10:41

BhaveshHeliconia requested a review from pedrobaeza January 2, 2026 10:45

Uh oh!

[19.0] [MIG] contract: Migration to 19.0 #1312

Are you sure you want to change the base?

[19.0] [MIG] contract: Migration to 19.0 #1312

Uh oh!

Conversation

BhaveshHeliconia commented Oct 1, 2025

Uh oh!

pedrobaeza commented Nov 24, 2025

Uh oh!

BhaveshHeliconia commented Nov 25, 2025

Uh oh!

carlos-lopez-tecnativa commented Nov 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

BhaveshHeliconia commented Nov 25, 2025

Uh oh!

victoralmau commented Nov 28, 2025

Uh oh!

BhaveshHeliconia commented Dec 2, 2025

Uh oh!

pedrobaeza commented Dec 9, 2025

Uh oh!

bosd left a comment

Choose a reason for hiding this comment

Uh oh!

pedrobaeza left a comment

Choose a reason for hiding this comment

Uh oh!

pedrobaeza Dec 31, 2025

Choose a reason for hiding this comment

Uh oh!

pedrobaeza Dec 31, 2025

Choose a reason for hiding this comment

Uh oh!

BhaveshHeliconia Jan 2, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

carlos-lopez-tecnativa commented Nov 25, 2025 •

edited

Loading