[19.0][MIG]: account_banking_mandate #1511
Open
+24,484
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Bug OCA#96 bad use of new API * [Usability] mandates: search by reference, add group_by, add seq type in tree view * Add scheme in mandate tree+search view * Replace tabs by spaces in mandate views * account_banking_mandate/views/account_banking_mandate_view.xml: convert from dos to unix format * Add multi-company rule on account.banking.mandate
Fix an important regression in account_banking_sepa_direct_debit: "Date of Last Debit" was not set any more Proper write of date_done with account_banking_payment_export is installed without account_banking_payment_transfer Add post-install script for date_sent on payment.order
The restriction rule Banking Mandate multi-company, gives an error when editing a partner bank account from a company A when that account has created a mandate from another company B. So it is impossible to create a mandate for each company without disabling the rule. Solution: Uncheck the rule writte in Banking Mandate multi-company. But i'm not sure this is correct.
* Short headers * Bump version numbers * es translations
* Add creditor identifier field to report mandate. * Translate. * Split basic and sepa mandate * Use api.multi instead * Make format field required
Port almost all modules to v10 * Update to EPC Rulebook v9.2 that start to apply on 2016-11-20 (bug OCA#300)
…ovided Using same method as in upstream, mandate is filled on invoice creation if no one is provided. This way, we don't need to install account_banking_mandate_sale if we don't want to handle several mandates at sales level.
…date + Add valid_mandate field and fix onchange (cherry picked from commit 25d2e4d)
add tests and constrains
* Fix tests due to upstream change Odoo has added a constraint for avoiding a company currency change if there are move lines, making these tests to fail, as the currency is changed to EUR. With this commit, we create a new company with EUR currency for avoiding the problem. This commit also changes account_banking_mandate for not duplicating mandate number, as it was detected during the test creation. Similar to 1f8e345 * Avoid errors in tests when run with other modules * More adaptations to make tests to work properly All these problems comes from using demo data.
So multi-company environment won't work correctly.
* Adapted test * Removed unneeded constraint * Fixed view for accessibility
The searches in the constraint should be done as sudo since it should not depend on the access of the user
It allows a user with no access on payment line to open mandates
Currently translated at 98.0% (99 of 101 strings) Translation: bank-payment-18.0/bank-payment-18.0-account_banking_mandate Translate-URL: https://translation.odoo-community.org/projects/bank-payment-18-0/bank-payment-18-0-account_banking_mandate/fr/
Currently translated at 100.0% (101 of 101 strings) Translation: bank-payment-18.0/bank-payment-18.0-account_banking_mandate Translate-URL: https://translation.odoo-community.org/projects/bank-payment-18-0/bank-payment-18-0-account_banking_mandate/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: bank-payment-18.0/bank-payment-18.0-account_banking_mandate Translate-URL: https://translation.odoo-community.org/projects/bank-payment-18-0/bank-payment-18-0-account_banking_mandate/
Currently translated at 100.0% (104 of 104 strings) Translation: bank-payment-18.0/bank-payment-18.0-account_banking_mandate Translate-URL: https://translation.odoo-community.org/projects/bank-payment-18-0/bank-payment-18-0-account_banking_mandate/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: bank-payment-18.0/bank-payment-18.0-account_banking_mandate Translate-URL: https://translation.odoo-community.org/projects/bank-payment-18-0/bank-payment-18-0-account_banking_mandate/
Alexgars73
force-pushed
the
19.0-mig-account_banking_mandate
branch
3 times, most recently
from
63dd92b to
0a0bfb9
Compare
Comment on lines
35
to
39
| commercial_partner_id = partner.commercial_partner_id.id | ||
| if commercial_partner_id in mandates_dic: | ||
| partner.valid_mandate_id = mandates_dic[commercial_partner_id] | ||
| else: | ||
| mandates = partner.commercial_partner_id.bank_ids.mapped( |
Contributor
There was a problem hiding this comment.
Suggested change
| commercial_partner_id = partner.commercial_partner_id.id | |
| if commercial_partner_id in mandates_dic: | |
| partner.valid_mandate_id = mandates_dic[commercial_partner_id] | |
| else: | |
| mandates = partner.commercial_partner_id.bank_ids.mapped( | |
| commercial_partner = partner.commercial_partner_id | |
| if commercial_partner.id in mandates_dic: | |
| partner.valid_mandate_id = mandates_dic[commercial_partner_id.id] | |
| else: | |
| mandates = commercial_partner.bank_ids.mapped( |
| ) | ||
| first_valid_mandate_id = mandates[:1].id | ||
| partner.valid_mandate_id = first_valid_mandate_id | ||
| mandates_dic[commercial_partner_id] = first_valid_mandate_id |
Contributor
There was a problem hiding this comment.
Suggested change
| mandates_dic[commercial_partner_id] = first_valid_mandate_id | |
| mandates_dic[commercial_partner.id] = first_valid_mandate_id |
Alexgars73
force-pushed
the
19.0-mig-account_banking_mandate
branch
from
0a0bfb9 to
c695780
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standard migration to v19.0
Depends #1510