[18.0][FIX] account_payment: prevent filtering valid write-off lines with balance only

[xaviedoanhduy]

Problem: In _prepare_move_line_default_vals, there is a filter designed to remove empty move lines (where both debit and credit are 0). However, upstream code sometimes generates write-off lines containing only a balance key (see), missing explicit debit or credit keys. In such cases, vals['debit'] and vals['credit'] returns 0.0, causing the filter to incorrectly identify these valid lines as empty and drop them or raising an error:

File ".../account_payment_line/models/account_payment.py", line 130, in _prepare_move_line_default_vals
    if not (vals["debit"] == 0.0 and vals["credit"] == 0.0)
KeyError: 'debit'

Solution: Update the filtering condition to include the balance key. A line is now considered empty and removed only if debit, credit, AND balance are all zero. This approach preserves valid write-off lines (which have a non-zero balance) without needing to mutate the input vals_list.

[OCA-git-bot]

Hi @ChrisOForgeFlow,
some modules you are maintaining are being modified, check this out!

[OCA-git-bot]

Hi @ChrisOForgeFlow,
some modules you are maintaining are being modified, check this out!