-
-
Notifications
You must be signed in to change notification settings - Fork 784
[16.0][OU-IMP] base: Review existent states and compare with installed states in order to update them properly #4509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
etobella
wants to merge
1
commit into
OCA:16.0
Choose a base branch
from
dixmit:16.0-states
base: 16.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,13 @@ | ||
| # Copyright 2020 Odoo Community Association (OCA) | ||
| # Copyright 2020 Opener B.V. <stefan@opener.am> | ||
| # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl). | ||
| import csv | ||
| import logging | ||
|
|
||
| from openupgradelib import openupgrade | ||
|
|
||
| from odoo import tools | ||
| from odoo.modules.module import get_resource_path | ||
|
|
||
| from odoo.addons.openupgrade_scripts.apriori import merged_modules, renamed_modules | ||
|
|
||
|
|
@@ -113,6 +115,29 @@ def update_translatable_fields(cr): | |
| ) | ||
|
|
||
|
|
||
| def _review_states_xmlids(cr): | ||
| data_file = open(get_resource_path("base", "data", "res.country.state.csv"), "r") | ||
| data_file.seek(0) | ||
| reader = csv.DictReader(data_file) | ||
| for row in reader: | ||
| cr.execute( | ||
| """ | ||
| SELECT rcs.id | ||
| FROM res_country_state rcs | ||
| JOIN res_country rc ON rc.id = rcs.country_id | ||
| JOIN | ||
| ir_model_data imd ON imd.res_id = rc.id | ||
| AND imd.model = 'res.country' | ||
| AND imd.module = 'base' | ||
| WHERE rcs.code = %s AND imd.name = %s | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is |
||
| """, | ||
| (row["code"], row["country_id:id"]), | ||
| ) | ||
| result = cr.fetchone() | ||
| if result: | ||
| openupgrade.add_xmlid(cr, "base", row["id"], "res.country.state", result[0]) | ||
|
|
||
|
|
||
| @openupgrade.migrate(use_env=False) | ||
| def migrate(cr, version): | ||
| """ | ||
|
|
@@ -139,3 +164,4 @@ def migrate(cr, version): | |
| ) | ||
| # update all translatable fields | ||
| update_translatable_fields(cr) | ||
| _review_states_xmlids(cr) | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add docstring to explain the purpose of this.