Skip to content

[14.0][MIG] mrp_production_request -> mrp_request #2618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
MiquelRForgeFlow wants to merge 1 commit into
base: 14.0
Choose a base branch
from
Open

[14.0][MIG] mrp_production_request -> mrp_request #2618

MiquelRForgeFlow wants to merge 1 commit into from

Conversation

@MiquelRForgeFlow
Copy link
Contributor

@MiquelRForgeFlow MiquelRForgeFlow commented Mar 18, 2021

Migration done in OCA/manufacture#625.

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@MiquelRForgeFlow MiquelRForgeFlow added this to the 14.0 milestone Mar 18, 2021
@MiquelRForgeFlow MiquelRForgeFlow mentioned this pull request Mar 18, 2021
Closed
9 tasks
@MiquelRForgeFlow
Copy link
Contributor Author

MiquelRForgeFlow commented Mar 18, 2021 •
edited
Loading

Why did you add the "blocked by dependency" tag? It's a non standard module, so it doesn't affect to the CI.

@StefanRijnhart
Copy link
Member

StefanRijnhart commented Mar 18, 2021

Oh, I added the blocked by dependency tag because the related PR on OCA/manufacture is not yet merged. Should they not be merged in tandem?

@MiquelRForgeFlow
Copy link
Contributor Author

MiquelRForgeFlow commented Mar 18, 2021

Not needed. It's not like anyone with that module in their databases will migrate their anytime soon haha

@StefanRijnhart
Copy link
Member

StefanRijnhart commented Mar 18, 2021

Well, consider it a matter of opinion.

alan196
alan196 approved these changes Mar 18, 2021
View reviewed changes
Copy link

@alan196 alan196 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Mar 23, 2021

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza
Copy link
Member

pedrobaeza commented May 18, 2021

Please resolve conflicts

@pedrobaeza
Copy link
Member

pedrobaeza commented May 18, 2021

Anyways, the linked PR is still not yet merged.

@pedrobaeza
Copy link
Member

pedrobaeza commented Sep 26, 2022

The linked PR is still not merged. Is this going to happen one day, or should we close this?

@legalsylvain
Copy link
Contributor

legalsylvain commented May 2, 2023

ping @MiquelRForgeFlow. Could you rebase ?

@MiquelRForgeFlow
Copy link
Contributor Author

MiquelRForgeFlow commented May 3, 2023

I could. But I don't find it necessary until OCA/manufacture#625 is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StefanRijnhart StefanRijnhart StefanRijnhart approved these changes

+1 more reviewer

@alan196 alan196 alan196 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved needs review ready to merge Waiting

Projects

None yet

Milestone

14.0

Development

Successfully merging this pull request may close these issues.

6 participants

@MiquelRForgeFlow @StefanRijnhart @OCA-git-bot @pedrobaeza @legalsylvain @alan196