Skip to content

[14.0][FIX] mrp: handle multiple finished moves for product #1305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NL66278 wants to merge 1 commit into
base: 14.0
Choose a base branch
from
Open

[14.0][FIX] mrp: handle multiple finished moves for product #1305

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions addons/mrp/models/mrp_production.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -925,18 +925,21 @@ def _create_update_move_finished(self):
is used within onchanges.
"""
# keep manual entries
list_move_finished = [(4, move.id) for move in self.move_finished_ids.filtered(
lambda m: not m.byproduct_id and m.product_id != self.product_id)]
list_move_finished = []
moves_finished_values = self._get_moves_finished_values()
moves_byproduct_dict = {move.byproduct_id.id: move for move in self.move_finished_ids.filtered(lambda m: m.byproduct_id)}
move_finished = self.move_finished_ids.filtered(lambda m: m.product_id == self.product_id)
move_finished = self.move_finished_ids.filtered(
lambda m: m.product_id == self.product_id
and m.state not in ("done", "cancel")
)
for move_finished_values in moves_finished_values:
if move_finished_values.get('byproduct_id') in moves_byproduct_dict:
# update existing entries
list_move_finished += [(1, moves_byproduct_dict[move_finished_values['byproduct_id']].id, move_finished_values)]
elif move_finished_values.get('product_id') == self.product_id.id and move_finished:
list_move_finished += [(1, move_finished.id, move_finished_values)]
# Note that there might be multiple moves for the same product.
# Therefore we take the first,
list_move_finished += [(1, move_finished[0].id, move_finished_values)]
else:
# add new entries
list_move_finished += [(0, 0, move_finished_values)]
Expand Down