Skip to content

[14.0][FIX] base: KeyError when updating module after removing model with selection field #1287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alexis-via wants to merge 1 commit into
base: 14.0
Choose a base branch
from
Open

[14.0][FIX] base: KeyError when updating module after removing model with selection field #1287

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion odoo/addons/base/models/ir_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1425,12 +1425,14 @@ def safe_write(records, fname, value):
records.invalidate_cache([fname])

for selection in self:
Model = self.env[selection.field_id.model]
# The field may exist in database but not in registry. In this case
# we allow the field to be skipped, but for production this should
# be handled through a migration script. The ORM will take care of
# the orphaned 'ir.model.fields' down the stack, and will log a
# warning prompting the developer to write a migration script.
Model = self.env.get(selection.field_id.model)
if Model is None:
continue
field = Model._fields.get(selection.field_id.name)
if not field or not field.store or not Model._auto:
continue
Expand Down