Skip to content

[FIX] [16.0] defuse possible endless loop in groupby rendering #1272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thomaspaulb wants to merge 1 commit into
base: 16.0
Choose a base branch
from
Open

[FIX] [16.0] defuse possible endless loop in groupby rendering #1272

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions odoo/addons/base/models/ir_ui_view.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1316,10 +1316,10 @@ def _postprocess_tag_groupby(self, node, name_manager, node_info):
# contain fields on the comodel
name = node.get('name')
field = name_manager.model._fields.get(name)
if not field or not field.comodel_name:
if self.env.context.get('no_nested_groupby') or not field or not field.comodel_name:
return
# post-process the node as a nested view, and associate it to the field
self._postprocess_view(node, field.comodel_name, editable=False, parent_name_manager=name_manager)
self.with_context(no_nested_groupby=True)._postprocess_view(node, field.comodel_name, editable=False, parent_name_manager=name_manager)
name_manager.has_field(node, name)

def _postprocess_tag_label(self, node, name_manager, node_info):
Expand Down