Skip to content

Conversation

@kazutoiris
Copy link

@kazutoiris kazutoiris commented Jan 2, 2026

Resolve issue where 'Join' button was hidden when DisableChannelMuteButton is enabled

Description

In the Nnngram client, when the DisableChannelMuteButton setting was enabled, the 'Join' button was also hidden along with the 'Mute/Unmute' button.

Issues Fixed or Closed by This PR

Same as PreviousAlone/Nnngram:#85.

Check List

  • I have tested the changes and verified that they work and don't break anything(as well as I can manage) or drop the support for previous versions.
  • My code follows the code style of this project
  • I have merged commits that are meaningless for follow-up work and confirmed that they will not cause damage to follow-up maintenance

Summary by Sourcery

Bug Fixes:

  • Ensure the DisableChannelMuteButton setting only hides the mute/unmute control and does not hide the Join button for broadcast channels.

- Fixed a bug where enabling the 'DisableChannelMuteButton' setting not only hid the 'Mute/Unmute' button but also inadvertently hid the 'Join' button.
@sourcery-ai
Copy link

sourcery-ai bot commented Jan 2, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adjusts the logic that hides the bottom overlay when DisableChannelMuteButton is enabled so that it only hides controls for channels the user is already a member of, ensuring the 'Join' button remains visible for channels the user has not joined yet.

File-Level Changes

Change Details Files
Tightened the condition for hiding the bottom overlay when the DisableChannelMuteButton setting is active so it applies only if the user is already in the channel.
  • Added a requirement that the current chat must be a channel the user is currently in before hiding the bottom overlay.
  • Preserved existing constraints: default chat mode, not a report chat, non-null chat, channel type, broadcast channel, and read-only (cannot write) state.
TMessagesProj/src/main/java/org/telegram/ui/ChatActivity.java

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant