fix(routes): show system routes table even if no custom routes are defined #682
+32
−26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the
RoutesContent.vuecomponent to improve icon usage, loading state handling, and UI consistency. The changes primarily focus on showing the system routes table even if no custom routes are defined.Tables
&& routes.lengthcondition on the main<div>containing the two tables to allow the system routes table view even if no custom routes are defined.Icon usage improvements:
['fas', 'circle-info']) with imported icon variables (e.g.,faCircleInfo,faTable,faPenToSquare, etc.), ensuring more consistent and type-safe icon handling throughout the component.Loading state and error handling:
loading.value = trueandloading.value = falsehandling in theloadMainTablefunction to ensure the loading skeleton is displayed correctly during data fetching, and always hidden after completion or error.UI and user experience enhancements:
Closes: NethServer/nethsecurity#1447