-
Notifications
You must be signed in to change notification settings - Fork 445
Add fabric manager configuration support #2045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
c221ff7
54dd493
b994d43
e974db0
53f8e81
c59ba01
28c95d9
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,8 +22,14 @@ data: | |
| fi | ||
|
|
||
| if ! nvidia-smi; then | ||
| echo "nvidia-smi failed" | ||
| exit 1 | ||
| # For vm-passthrough with shared-nvswitch mode, nvidia-smi may fail due to unbound devices | ||
| # Fall back to checking if nvidia module is loaded when FABRIC_MANAGER_FABRIC_MODE=1 | ||
| if [ "${FABRIC_MANAGER_FABRIC_MODE:-}" = "1" ] && lsmod | grep -q "^nvidia "; then | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Question -- isn't the right-hand-side of this if statement redundant? Don't we already know the nvidia module is loaded prior to this (see L19-22)? |
||
| echo "nvidia-smi failed but nvidia module is loaded (vm-passthrough with shared-nvswitch mode)" | ||
| else | ||
| echo "nvidia-smi failed" | ||
| exit 1 | ||
| fi | ||
| fi | ||
|
|
||
| GPU_DIRECT_RDMA_ENABLED="${GPU_DIRECT_RDMA_ENABLED:-false}" | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question (for my understanding) -- GPUs may not be bound to the
nvidiadriver since there is a chance that thevfio-managerran already and unbound the devices? Am I understanding this correct?