[PyTorch] Fix garbage initialized permuted_scale #2547
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a NaN issue in the fused permute+pad path when handling Float8BlockwiseQTensor inputs.
Since
torch.emptydoes not initialize memory, these buffers could contain NaN values in the padded regions.When the permute input is a
Float8BlockwiseQTensor, if the correspondingpermuted_scaleentries in the padded region contain NaNs, these NaNs can propagate through the subsequent dequantization and requantization path inGroupedLinear, eventually resulting in a NaN forward loss, e.g.:ERROR:megatron.core.rerun_state_machine:Unexpected result nan on rank 1 at iteration #2 invocation #1 (message='found NaN in local forward loss calculation')Type of change
Changes
Please list the changes introduced in this PR:
permute_with_mask_mapChecklist: