Ko3n1g/pranav/ray k8s issue debug #562
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pranav Prashant Thombre <pthombre@nvidia.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
ko3n1g
requested review from
athitten,
oyilmaz-nvidia and
pthombre
as code owners
Signed-off-by: oliver könig <okoenig@nvidia.com>
pthombre
reviewed
Jan 20, 2026
| **model_config_kwargs, | ||
| ): | ||
| # Use replica-specific environment variables to avoid conflicts | ||
| master_addr = "127.0.0.1" |
Contributor
There was a problem hiding this comment.
What is the need to hard code the master address and port here?
ko3n1g
force-pushed
the
ko3n1g/pranav/ray_k8s_issue_debug
branch
from
a6c94ee to
7ed9663
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We shouldn't merge it like this, I think this will have negative side-effects on Slurm deployments. But on Kubernetes with the KubeRay operator, this solves the init hang.