Skip to content

Cleanup logging and f-strings #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Lorenyx wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Cleanup logging and f-strings #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
398d3c5
Update unknown kwargs to log as debug
Lorenyx Aug 9, 2025
888af34
Resolve pylint W1309
Lorenyx Aug 10, 2025
82a8446
Resolve pylint W1203
Lorenyx Aug 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mythic_container/AuthBase.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,5 +312,5 @@ async def SendMythicRPCSyncAuth(auth_name: str) -> bool:
await mythic_container.mythic_service.syncAuthData(auth)
return True
return False
except Exception as e:
except:
return False
40 changes: 20 additions & 20 deletions mythic_container/C2ProfileBase.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ def __init__(self,
self.Name = c2_profile_name
self.Parameters = parameters
for k, v in kwargs.items():
logger.error(f"unknown kwarg {k} {v}")
logger.debug("Unknown kwarg %s: %s", k, v)

def to_json(self) -> dict:
return {
Expand Down Expand Up @@ -61,7 +61,7 @@ def __init__(self,
self.Message = Message
self.RestartInternalServer = RestartInternalServer
for k, v in kwargs.items():
logger.error(f"unknown kwarg {k} {v}")
logger.debug("Unknown kwarg %s: %s", k, v)

def to_json(self):
return {
Expand Down Expand Up @@ -92,7 +92,7 @@ def __init__(self,
self.Name = c2_profile_name
self.Parameters = parameters
for k, v in kwargs.items():
logger.error(f"unknown kwarg {k} {v}")
logger.debug("Unknown kwarg %s: %s", k, v)

def to_json(self):
return {
Expand Down Expand Up @@ -127,7 +127,7 @@ def __init__(self,
self.Message = Message
self.RestartInternalServer = RestartInternalServer
for k, v in kwargs.items():
logger.error(f"unknown kwarg {k} {v}")
logger.debug("Unknown kwarg %s: %s", k, v)

def to_json(self):
return {
Expand Down Expand Up @@ -158,7 +158,7 @@ def __init__(self,
self.Name = c2_profile_name
self.Parameters = parameters
for k, v in kwargs.items():
logger.error(f"unknown kwarg {k} {v}")
logger.debug("Unknown kwarg %s: %s", k, v)

def to_json(self):
return {
Expand Down Expand Up @@ -213,7 +213,7 @@ def __init__(self,
self.IOCs = IOCs
self.RestartInternalServer = RestartInternalServer
for k, v in kwargs.items():
logger.error(f"unknown kwarg {k} {v}")
logger.debug("Unknown kwarg %s: %s", k, v)

def to_json(self):
return {
Expand Down Expand Up @@ -244,7 +244,7 @@ def __init__(self,
self.Name = c2_profile_name
self.Parameters = parameters
for k, v in kwargs.items():
logger.error(f"unknown kwarg {k} {v}")
logger.debug("Unknown kwarg %s: %s", k, v)

def to_json(self):
return {
Expand Down Expand Up @@ -279,7 +279,7 @@ def __init__(self,
self.Message = Message
self.RestartInternalServer = RestartInternalServer
for k, v in kwargs.items():
logger.error(f"unknown kwarg {k} {v}")
logger.debug("Unknown kwarg %s: %s", k, v)

def to_json(self):
return {
Expand Down Expand Up @@ -307,7 +307,7 @@ def __init__(self,
**kwargs):
self.Name = c2_profile_name
for k, v in kwargs.items():
logger.error(f"unknown kwarg {k} {v}")
logger.debug("Unknown kwarg %s: %s", k, v)

def to_json(self):
return {
Expand Down Expand Up @@ -344,7 +344,7 @@ def __init__(self,
self.InternalServerRunning = InternalServerRunning
self.RestartInternalServer = RestartInternalServer
for k, v in kwargs.items():
logger.error(f"unknown kwarg {k} {v}")
logger.debug("Unknown kwarg %s: %s", k, v)

def to_json(self):
return {
Expand Down Expand Up @@ -376,7 +376,7 @@ def __init__(self,
self.Name = c2_profile_name
self.Parameters = parameters
for k, v in kwargs.items():
logger.error(f"unknown kwarg {k} {v}")
logger.debug("Unknown kwarg %s: %s", k, v)

def to_json(self):
return {
Expand Down Expand Up @@ -411,7 +411,7 @@ def __init__(self,
self.Message = Message
self.RestartInternalServer = RestartInternalServer
for k, v in kwargs.items():
logger.error(f"unknown kwarg {k} {v}")
logger.debug("Unknown kwarg %s: %s", k, v)

def to_json(self):
return {
Expand Down Expand Up @@ -439,7 +439,7 @@ def __init__(self,
**kwargs):
self.Name = c2_profile_name
for k, v in kwargs.items():
logger.error(f"unknown kwarg {k} {v}")
logger.debug("Unknown kwarg %s: %s", k, v)

def to_json(self):
return {
Expand Down Expand Up @@ -474,7 +474,7 @@ def __init__(self,
self.Message = Message
self.InternalServerRunning = InternalServerRunning
for k, v in kwargs.items():
logger.error(f"unknown kwarg {k} {v}")
logger.debug("Unknown kwarg %s: %s", k, v)

def to_json(self):
return {
Expand Down Expand Up @@ -503,7 +503,7 @@ def __init__(self,
**kwargs):
self.Name = c2_profile_name
for k, v in kwargs.items():
logger.error(f"unknown kwarg {k} {v}")
logger.debug("Unknown kwarg %s: %s", k, v)

def to_json(self):
return {
Expand Down Expand Up @@ -538,7 +538,7 @@ def __init__(self,
self.Message = Message
self.InternalServerRunning = InternalServerRunning
for k, v in kwargs.items():
logger.error(f"unknown kwarg {k} {v}")
logger.debug("Unknown kwarg %s: %s", k, v)

def to_json(self):
return {
Expand Down Expand Up @@ -582,7 +582,7 @@ def __init__(self,
if self.ServiceRPCFunctionArguments is None:
self.ServiceRPCFunctionArguments = service_arguments
for k, v in kwargs.items():
logger.error(f"unknown kwarg {k} {v}")
logger.debug("Unknown kwarg %s: %s", k, v)

def to_json(self):
return {
Expand Down Expand Up @@ -627,7 +627,7 @@ def __init__(self,
self.Result = result
self.RestartInternalServer = RestartInternalServer
for k, v in kwargs.items():
logger.error(f"unknown kwarg {k} {v}")
logger.debug("Unknown kwarg %s: %s", k, v)

def to_json(self):
return {
Expand Down Expand Up @@ -664,7 +664,7 @@ def __init__(self,
self.HostURL = host_url
self.Remove = remove
for k, v in kwargs.items():
logger.error(f"unknown kwarg {k} {v}")
logger.debug("Unknown kwarg %s: %s", k, v)

def to_json(self):
return {
Expand Down Expand Up @@ -698,7 +698,7 @@ def __init__(self,
self.Error = Error
self.RestartInternalServer = RestartInternalServer
for k, v in kwargs.items():
logger.error(f"unknown kwarg {k} {v}")
logger.debug("Unknown kwarg %s: %s", k, v)

def to_json(self):
return {
Expand Down
2 changes: 1 addition & 1 deletion mythic_container/EventingBase.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,5 +345,5 @@ async def SendMythicRPCSyncEventing(eventing_name: str) -> bool:
await mythic_container.mythic_service.syncEventingData(event)
return True
return False
except Exception as e:
except:
return False
18 changes: 9 additions & 9 deletions mythic_container/LoggingBase.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ def __init__(self,
self.LockedOperatorID = locked_operator_id
self.Timestamp = timestamp
for k, v in kwargs.items():
logger.info(f"unknown kwarg {k} with value {v}")
logger.debug("Unknown kwarg %s: %s", k, v)

def to_json(self):
return {
Expand Down Expand Up @@ -182,7 +182,7 @@ def __init__(self,
self.OperationID = operation_id
self.Host = host
for k, v in kwargs.items():
logger.info(f"unknown kwarg {k} with value {v}")
logger.debug("Unknown kwarg %s: %s", k, v)

def to_json(self):
return {
Expand Down Expand Up @@ -252,7 +252,7 @@ def __init__(self,
self.Comment = comment
self.Deleted = deleted
for k, v in kwargs.items():
logger.info(f"unknown kwarg {k} with value {v}")
logger.debug("Unknown kwarg %s: %s", k, v)

def to_json(self):
return {
Expand Down Expand Up @@ -371,7 +371,7 @@ def __init__(self,
self.SHA1 = sha1
self.Comment = comment
for k, v in kwargs.items():
logger.info(f"unknown kwarg {k} with value {v}")
logger.debug("Unknown kwarg %s: %s", k, v)

def to_json(self):
return {
Expand Down Expand Up @@ -442,7 +442,7 @@ def __init__(self,
self.Window = window
self.User = user
for k, v in kwargs.items():
logger.info(f"unknown kwarg {k} with value {v}")
logger.debug("Unknown kwarg %s: %s", k, v)

def to_json(self):
return {
Expand Down Expand Up @@ -548,7 +548,7 @@ def __init__(self,
self.TaskID = task_id
self.FileID = file_id
for k, v in kwargs.items():
logger.info(f"unknown kwarg {k} with value {v}")
logger.debug("Unknown kwarg %s: %s", k, v)

def to_json(self):
return {
Expand Down Expand Up @@ -606,7 +606,7 @@ def __init__(self,
self.Response = base64.b64decode(response).decode()
self.Timestamp = timestamp
for k, v in kwargs.items():
logger.info(f"unknown kwarg {k} with value {v}")
logger.debug("Unknown kwarg %s: %s", k, v)

def to_json(self):
return {
Expand Down Expand Up @@ -675,7 +675,7 @@ def __init__(self,
else:
self.Data = data
for k, v in kwargs.items():
logger.info(f"unknown kwarg {k} {v}")
logger.debug("Unknown kwarg %s: %s", k, v)

def to_json(self):
return {
Expand Down Expand Up @@ -785,5 +785,5 @@ async def SendMythicRPCSyncLogger(logger_name: str) -> bool:
await mythic_container.mythic_service.syncLoggingData(log)
return True
return False
except Exception as e:
except:
return False
Loading