Fix getting "false positive" items from namesake groups #59
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the issue when there is a group with the same name as the source group and "Replicate group only" feature is used so this will replicate redundant items..
There is no restriction in KiCad for namesake groups.
But each group must be an individual entity.
Comparing items' parent groups by its' entity should prevent from confusion source group with other namesake groups.
It may produce such a mess at https://github.com/MitjaNemec/ReplicateLayout/blob/62278e94812c5ef6d706d1a8ecc9758a4381b591/replicate_layout.py#L1305 but I cant figure out how to handle it properly, because "group name" will no longer make any sense I think but
<Swig Object of type 'PCB_GROUP *' at 0xXXXXXXXXXXXXXXXX>may be "unreadable".I think it should be done for
filter_items_by_groupandfilter_footprints_by_groupalso. But I did not find it used anywhere.