-
Notifications
You must be signed in to change notification settings - Fork 835
Fix critical logic error and improve error handling in PowerShell token script docs #1839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix critical logic error and improve error handling in PowerShell token script docs #1839
Conversation
|
@microsoft-github-policy-service agree |
|
@RustyTake-Off : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change. |
|
Learn Build status updates of commit 6a62f3d: ✅ Validation status: passed
For more details, please refer to the build report. |
PRMerger Results
|
|
Can you review the proposed changes? Important: When the changes are ready for publication, adding a #label:"aq-pr-triaged" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes a critical logic error in the PowerShell token acquisition script documentation and enhances error handling throughout. The main issue addressed is that the script would continue executing even when the connector module installation failed, leading to runtime errors.
Key Changes
- Critical logic fix: Wrapped the main script logic (lines 87-161) inside the module existence check to prevent execution when installation fails
- Improved process execution: Added
-Waitparameter toStart-Processcalls to ensure installers complete before continuing - Enhanced error handling: Added existence checks and
-ErrorAction SilentlyContinuefor cleanup operations to prevent failures during cleanup
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
Fixed critical logic error and improved error handling in the PowerShell token acquisition script docs.
Issues Fixed
Testing