Skip to content

refactor: remove required biometrics for hmac key for now #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
salis merged 3 commits into from
Jan 21, 2026
Merged

refactor: remove required biometrics for hmac key for now #10

salis merged 3 commits into from
Jan 21, 2026

Conversation

@0x330a
Copy link
Contributor

@0x330a 0x330a commented Jan 21, 2026

Summary

  • Prevent keystore2.rs error on no biometrics for hmacSha256 key when trying to use in release mode

Context

  • Links: issue, ticket, or related PRs.

Changes

  • Short bullet list of the key changes made.

Checklist

  • Tests added/updated
  • Docs updated (if needed)

Risks

  • Brief note about possible risks or impact.

How to test

  • Short, reproducible steps to verify the change.
    z

@0x330a 0x330a requested a review from a team as a code owner January 21, 2026 03:31
@0x330a 0x330a requested review from salis and removed request for a team January 21, 2026 03:32
salis
salis previously approved these changes Jan 21, 2026
View reviewed changes
@salis salis merged commit de132a9 into main Jan 21, 2026
1 check passed
@salis salis deleted the fix/disable-biometrics-for-hmac branch January 21, 2026 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@salis salis salis approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@0x330a @salis