feat: Add watchAsset origin metadata fallbacks #7612
Merged
+135
−32
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle optional origin/pageMeta inputs in watchAsset approvals. Add tests covering empty-string origin fallbacks and requestMetadata precedence.
Explanation
References
Related to https://github.com/MetaMask/mobile-planning/issues/2395
Checklist
Note
Enhances
watchAssetapproval flow with origin/page metadata handling and safer defaults.TokensController.watchAssetaccepts optionalorigin,pageMeta, andrequestMetadata; origin resolves viagetNonEmptyStringwith fallback toORIGIN_METAMASK, andpageMetais forwarded inrequestData.metadataSuggestedAssetMetaand addsWatchAssetRequestMetadata; importsJson; newgetNonEmptyStringhelperimagetonull||to??and adds trim checks when defaulting token image URLsrequestMetadata.originprecedencewatchAssetorigin/page metadata supportWritten by Cursor Bugbot for commit ecdce6d. This will update automatically on new commits. Configure here.