Skip to content

feat: improve currency rate fallback logic #7606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Prithpal-Sooriya wants to merge 10 commits into
base: main
Choose a base branch
from
+639 −99
Open

feat: improve currency rate fallback logic #7606

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
8739076
Cursor: Apply local changes for cloud agent
Prithpal-Sooriya Jan 12, 2026
bebd9be
refactor(CurrencyRateController): clean up fallback logic and add tests
Prithpal-Sooriya Jan 12, 2026
b7809cd
chore: prune unused eslint suppressions for CurrencyRateController
Prithpal-Sooriya Jan 12, 2026
236f510
refactor: improve #fetchRatesFromTokenPricesService to return rates a…
Prithpal-Sooriya Jan 12, 2026
548606f
refactor: move try-catch inside #fetchRatesFromTokenPricesService
Prithpal-Sooriya Jan 12, 2026
1561366
Checkpoint before follow-up message
cursoragent Jan 12, 2026
2a0fd88
docs: add changelog entry for CurrencyRateController refactoring
Prithpal-Sooriya Jan 12, 2026
f9ff877
style: add missing trailing newline to eslint-suppressions.json
cursoragent Jan 12, 2026
9b81e9e
Merge main into feature branch
Prithpal-Sooriya Jan 13, 2026
bdec20c
Merge latest main into feature branch
Prithpal-Sooriya Jan 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions eslint-suppressions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,13 +187,7 @@
},
"packages/assets-controllers/src/CurrencyRateController.ts": {
"@typescript-eslint/explicit-function-return-type": {
"count": 3
},
"no-negated-condition": {
"count": 1
},
"no-restricted-syntax": {
"count": 3
}
},
"packages/assets-controllers/src/DeFiPositionsController/DeFiPositionsController.test.ts": {
Expand Down
3 changes: 3 additions & 0 deletions packages/assets-controllers/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Bump `@metamask/polling-controller` from `^16.0.0` to `^16.0.1` ([#7604](https://github.com/MetaMask/core/pull/7604))
- Update Plasma (0x2611) mapping to eip155:9745/erc20:0xeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee for XPL ([#7601](https://github.com/MetaMask/core/pull/7601))
- `TokensController.watchAsset` now supports optional origin/page metadata and safely falls back for empty origins to avoid rejected approvals ([#7612](https://github.com/MetaMask/core/pull/7612))
- Refactor `CurrencyRateController` exchange rate fetching with improved fallback logic ([#7606](https://github.com/MetaMask/core/pull/7606))
- Improved partial success handling: when some currencies succeed via the Price API and others fail, only failed currencies trigger the fallback mechanism
- Extracted helper methods for better code organization and testability

## [95.1.0]

Expand Down
Loading
Loading