-
Notifications
You must be signed in to change notification settings - Fork 4
[TESTING REQUIRED] A complete Code Refactor + New Features (History View, Image Processing Presets and Modifier Key support) #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Wow, you did... what?? This is crazy! EDIT: Numbad not working as hotkey. Mouse buttons not working as hotkey. Mouse button Left/Right is not as hotkey even if checked. Program Saves.. Button (not opening the \AppData\Local\Temp\GameReader folder) "bug" Window scaling, you already know this. Not a rush at all but.. |
Yes, this code is pretty much very Pre-Alpha, this is why I don't want you rush this thing out of the Pull Request. We, or at least me, have a lot of time to work the kinks out and fix anything in the weeks ahead in July. You should be able to send your own commits into https://github.com/ThomasEricB/GameReader/tree/CodeRefactor (my CodeRefractor branch) if need want as well. I'm also somewhat of a code newbie as well, mostly using AI to guide me. Though I've done some beginner code courses here and there however, so I'm not completely green. If we are too lost, I made this in a way that we can just revert most of the Problematic python methods back and the code should work again.
I think a 0.9 would be more appropriate. I've made a list of stuff we may want to add to the software after we finish with this version for 1.0. If you allow me:
However, for now, so we don't completely modify the code even more, I'll focus on fixing whatever you report to me and integrate RealtimeTTS better! |
|
@MertenNor Do you have discord, by the way? If you want to contact me easily, you can add me there, it's just vincentvanvega . If you don't, but you use steam, you can reach me on https://steamcommunity.com/id/thombelcar/ |
Co-authored-by: MertenNor <p1morten@gmail.com>
|
Add:
Needed Fixes:
|
Co-authored-by: MertenNor <p1morten@gmail.com>
Co-authored-by: MertenNor <p1morten@gmail.com>
Co-authored-by: MertenNor <p1morten@gmail.com>
This might come as a surprise to you, but... I just spent the last 2 days refactoring the entire code, cleaning it up and optimizing it. I went line by line to be certain that there would be no regressions. Still, there might have a few bugs or stuff I missed. Make sure to test all functions before accepting this PR, as I was unable to test some. I also need to fix the window geometry because it's somewhat off.
New features:
OCR Text History Viewer
Added an OCR Text History Viewer for convenience to each read area!
Modifier Keys (Ctrl, Shift, Alt) Support
The code now captures active modifiers (Ctrl, Shift, Alt) and combines them with a primary key or mouse button!
Image Processing presets
Added the ability to Load and Save presets of Image Processing filters.
This is might not be the end of the PR. Tonight I'll try to import RealtimeTTS into this.