Skip to content

Conversation

@ThomasEricB
Copy link
Collaborator

@ThomasEricB ThomasEricB commented Jun 30, 2025

This might come as a surprise to you, but... I just spent the last 2 days refactoring the entire code, cleaning it up and optimizing it. I went line by line to be certain that there would be no regressions. Still, there might have a few bugs or stuff I missed. Make sure to test all functions before accepting this PR, as I was unable to test some. I also need to fix the window geometry because it's somewhat off.

New features:

OCR Text History Viewer

Added an OCR Text History Viewer for convenience to each read area!

python_JK4ntPnHJv

Modifier Keys (Ctrl, Shift, Alt) Support

The code now captures active modifiers (Ctrl, Shift, Alt) and combines them with a primary key or mouse button!

python_p8McWPickE

Image Processing presets

Added the ability to Load and Save presets of Image Processing filters.

python_DAcIbgS8XG


This is might not be the end of the PR. Tonight I'll try to import RealtimeTTS into this.

@MertenNor
Copy link
Owner

MertenNor commented Jul 1, 2025

Wow, you did... what?? This is crazy!
I never thought someone would take the time to go through everything, turn it into real code, and even add extra features.
Thank you so much!
I’ve already noticed a few things that don’t work as intended.
I’ll go through everything and see what else I can find.
will report back in a bit.
There’s also this guy I’m in contact with on Reddit who always manages to find random bugs that I miss. I’ll compile a version for him later so we can be sure there are no bugs when this gets released at some point. oh, and guess we could treat this as a 1.0 release, what do you think?
I know my version releases aren’t exactly accurate.. I’m new to all of this, including GitHub, so excuse my way of doing things here.

EDIT:
BUGS:

Numbad not working as hotkey.
Nonbad not working as Stop Hotkey.

Mouse buttons not working as hotkey.
Mouse buttons not working as Stop Hotkey.

Mouse button Left/Right is not as hotkey even if checked.
Mouse button Left/Right is not as Stop hotkey even if checked.

Program Saves.. Button (not opening the \AppData\Local\Temp\GameReader folder)

"bug"
Highlighting text in the History window makes the text white. (hard to see)

Window scaling, you already know this.

Not a rush at all but..
Add a "Show All History" button that shows all areas.
Info/Help window is a little different (I updated this last update)

@ThomasEricB
Copy link
Collaborator Author

I’ve already noticed a few things that don’t work as intended.

Yes, this code is pretty much very Pre-Alpha, this is why I don't want you rush this thing out of the Pull Request. We, or at least me, have a lot of time to work the kinks out and fix anything in the weeks ahead in July. You should be able to send your own commits into https://github.com/ThomasEricB/GameReader/tree/CodeRefactor (my CodeRefractor branch) if need want as well. I'm also somewhat of a code newbie as well, mostly using AI to guide me. Though I've done some beginner code courses here and there however, so I'm not completely green. If we are too lost, I made this in a way that we can just revert most of the Problematic python methods back and the code should work again.

There’s also this guy I’m in contact with on Reddit who always manages to find random bugs that I miss. I’ll compile a version for him later so we can be sure there are no bugs when this gets released at some point. oh, and guess we could treat this as a 1.0 release, what do you think?

I think a 0.9 would be more appropriate. I've made a list of stuff we may want to add to the software after we finish with this version for 1.0. If you allow me:

  • Settings window and Configurable Save Locations
  • Recent Layouts Dropout Menu
  • Allow different voices for the same area using different hotkeys
  • Text Buffering Toggle for Long Texts
  • Post processing filter on TTS Voice (Reverb, echo, etc.)
  • Text-to-Speech Queue
  • Localization Support (so I can translate the menus and everything to Portuguese! And people can submit their own translations!)

However, for now, so we don't completely modify the code even more, I'll focus on fixing whatever you report to me and integrate RealtimeTTS better!

@ThomasEricB ThomasEricB marked this pull request as draft July 1, 2025 19:25
@ThomasEricB
Copy link
Collaborator Author

@MertenNor Do you have discord, by the way? If you want to contact me easily, you can add me there, it's just vincentvanvega . If you don't, but you use steam, you can reach me on https://steamcommunity.com/id/thombelcar/

Co-authored-by: MertenNor <p1morten@gmail.com>
@ThomasEricB
Copy link
Collaborator Author

ThomasEricB commented Jul 2, 2025

Add:

  • faster load time? (if easy to fix)
  • Volume% can only be 2 digits. (might have been a bug since way back)
  • newer info/help window from the latest release on GH.
  • a "show history" button for all areas, including auto read.
  • Program Saves. Button (not opening the \AppData\Local\Temp\GameReader folder),
  • Properly implement each RealtimeTTS engine

Needed Fixes:

  • Highlighting text in the History window makes the text white. (hard to see)
  • Window scaling
  • trying to save loadout, crashes the program.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants