Fix #7852 Command Console mechs with only one crew member were applying head hit damage twice to the single pilot instead of once. #7853
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7852
Command Console mechs with only one crew member were applying head hit damage twice to the single pilot instead of once.
Root Cause
The
damageCrew()method inTWGameManager.javaiterates through all crew slots based ongetSlotCount(), but did not check if a slot was actually occupied. For Command Console cockpits (which have 2 slots: Pilot + Commander), when only one crew member is present, the loop would still process both slots - applying damage to the missing slot as well.Fix
Added a check for
crew.isMissing(pos)to skip empty crew slots when applying damage. This is consistent with how other crew iteration loops handle missing slots (e.g.,Crew.java:932-935).