Fix #7015 - Show Spotting FOV for Mast Mount elevation bonus #7830
+88
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR Description: Summary Adds a "Show Spotting FOV" toggle that visualizes the +1 elevation bonus from Mast Mounts when determining what a VTOL can spot versus what it can directly fire at. Fixes #7015 Root Cause The FOV visualization in FovHighlightingAndDarkening.java calculates line-of-sight based solely on the unit's physical position without considering equipment modifiers. Per BattleTech rules, Mast Mount allows a VTOL to spot targets (for C3, TAG, artillery, indirect fire) as if it were one elevation level higher, but this bonus does NOT apply to direct fire attacks. The existing FOV display only showed what the unit could directly fire at, with no option to visualize the extended spotting range. This is a missing feature rather than broken logic - the game correctly applies the Mast Mount bonus during actual spotting resolution, but the visual FOV display had no mechanism to show this bonus to the player. Changes - New menu item: View > Show Spotting FOV (keyboard shortcut: O) - When enabled, FOV calculations include the +1 elevation bonus from Mast Mount equipment - Visual indicators when active: blue tint + reversed stripe direction - Automatically resets to OFF at game start to prevent player confusion
HammerGS
added
AI Generated Fix
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements a new "Show Spotting FOV" visualization mode that displays the extended line-of-sight range available when VTOLs use Mast Mount equipment for spotting (C3, TAG, indirect fire) versus direct fire attacks. Per BattleTech rules, Mast Mount provides a +1 elevation bonus for spotting but not for direct fire.
Key Changes:
- Added keyboard shortcut (O) and menu toggle for "Show Spotting FOV" mode
- Modified FOV calculations to apply Mast Mount +1 elevation bonus when spotting mode is enabled
- Visual distinction through blue tint and reversed stripe direction when active
- Automatic reset to OFF at game start
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| KeyCommandBind.java | Adds FOV_SPOTTING key binding with 'O' shortcut |
| FovHighlightingAndDarkening.java | Implements Mast Mount elevation bonus logic, adds cache clearing, and applies visual indicators (blue tint, reversed stripes) |
| BoardView.java | Extends drawHexLayer methods with reverseStripes parameter and implements gradient paint reversal logic |
| GUIPreferences.java | Adds FOV_SPOTTING_MODE preference with getter/setter methods |
| CommonMenuBar.java | Integrates new menu item with accelerator and preference change handling |
| ClientGUI.java | Handles toggle action and auto-resets spotting mode at game start |
| messages.properties | Adds menu label and tooltip text for the new feature |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
megamek/src/megamek/client/ui/clientGUI/boardview/FovHighlightingAndDarkening.java
Show resolved
Hide resolved
megamek/src/megamek/client/ui/clientGUI/boardview/FovHighlightingAndDarkening.java
Show resolved
Hide resolved
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
megamek/src/megamek/client/ui/clientGUI/boardview/BoardView.java
Dismissed
Show dismissed
Hide dismissed
Member
Author
|
Just a note on this. Our LOS and Spotting code is correct the issue is we don't show it with the hex shading. This is the Field of View. This is the Spotting Mode. (with a Mast Mount) |
HammerGS
added
the
AI ready for Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a "Show Spotting FOV" toggle that visualizes the +1 elevation bonus from Mast Mounts when determining what a VTOL can spot versus what it can directly fire at.
Fixes #7015
Root Cause
The FOV visualization in FovHighlightingAndDarkening.java calculates line-of-sight based solely on the unit's physical position without considering equipment modifiers. Per BattleTech rules, Mast Mount allows a VTOL to spot targets (for C3, TAG, artillery, indirect fire) as if it were one elevation level higher, but this bonus does NOT apply to direct fire attacks.
The existing FOV display only showed what the unit could directly fire at, with no option to visualize the extended
spotting range. This is a missing feature rather than broken logic - the game correctly applies the Mast Mount bonus during actual spotting resolution, but the visual FOV display had no mechanism to show this bonus to the player.
Changes