Add processing of multiple fluff images (WIP) #5490
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MegaMek + Fix 5476: Update SV armor slots to 2 or 1 for Rating E or F respectively MegaMekLab + Fix #MegaMek#1514: Fix Atrocious table shading render speed MekHQ + PR MegaMek#4106: Use tabs in customize scenario dialog + PR MegaMek#4105: Updated Post-Scenario Logging for Prisoners + PR MegaMek#4104: Fixed Post-Scenario Tracking System's Handling of Multiple Personnel in autoAwards + PR MegaMek#4102: Fixed Award Tier Count Calculations in PersonViewPanel + PR MegaMek#4093: Added Negotiation and Scrounge Skill Settings for Administrator Personnel + PR MegaMek#4054: Added Life Paths Campaign Options Tab, Added Education Module Very Important to read the documentation on this feature (See Docs folder)
# Conflicts: # megamek/docs/history.txt
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5490 +/- ##
============================================
- Coverage 29.15% 29.14% -0.02%
- Complexity 15415 15441 +26
============================================
Files 2865 2871 +6
Lines 280027 280357 +330
Branches 49307 49346 +39
============================================
+ Hits 81655 81718 +63
- Misses 192890 193153 +263
- Partials 5482 5486 +4 ☔ View full report in Codecov by Sentry. |
Destrier has Sponson Equipment in Inconsistent Location MegaMek#5865
HammerGS
added
the
For New Dev Cycle
Collaborator
|
9 months with no changes. Closing for now. Please re-open when updated. |
Member
|
Please leave open. |
# Conflicts: # megamek/data/mechfiles/vehicles/3145/Davion/Destrier Siege Vehicle.blk # megamek/src/megamek/client/ui/swing/MekViewPanel.java # megamek/src/megamek/client/ui/swing/util/FluffImageHelper.java
|
FWIW, I am super-happy to see this development happening. Can't wait to have it merged. |
…or to Reduce Ambiguity
…or to Reduce Ambiguity (MegaMek#7491) As per title. Nothing exciting here. As further action, it might make sense to rename 'TargetRoll' and 'TargetRollModifier' to 'TargetNumber' and 'TargetNumberModifier' to further reduce risk of confusion moving forward. Such confusion was the root cause of MegaMek/mekhq#7713
# Conflicts: # megamek/docs/AI and MegaMek Suite (Not Princess Stuff).txt # megamek/docs/history.txt # megamek/src/megamek/client/ui/FluffImageTooltip.java # megamek/src/megamek/client/ui/swing/MekViewPanel.java # megamek/src/megamek/client/ui/util/FluffImageHelper.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In development