-
Notifications
You must be signed in to change notification settings - Fork 3
Resolve #7 #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve #7 #17
Conversation
11f00a0 to
e32257b
Compare
* use template structures for improved code reuse * replace NonIntegerTimestampDataParametricMonitorFixture with the generic DataParametricMonitorFixture
e32257b to
63c7779
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request implements epsilon (unobservable) transition support in the BooleanMonitor class, following the same approach used in PR #15 for the DataParametricMonitor. The implementation adds the ability to handle transitions labeled with action ID 127 (unobservable actions) that can occur without consuming input events.
Changes:
- Implemented epsilon transition handling in BooleanMonitor with time advancement based on clock guards
- Refactored test fixtures to support both boolean and data parametric monitors with improved naming conventions
- Added comprehensive test coverage for epsilon transitions in various scenarios including guards, multiple clock variables, and accept state transitions
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
test/fixture/epsilon_transition_automaton_fixture.hh |
Added #pragma once, makeBooleanTA() method, made methods const, renamed constants to SCREAMING_SNAKE_CASE, and converted fixtures to inline const |
test/data_parametric_monitor_test.cc |
Updated to use refactored fixture names (FIXTURE1-4) and consolidated fixture structure |
test/boolean_monitor_test.cc |
Refactored with template-based fixtures and added four new epsilon transition test cases covering various scenarios |
src/boolean_monitor.hh |
Added epsilon transition support: Configuration now tracks absolute time, implemented epsilonTransition() method, destructor calls epsilon transitions for final processing |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Implement unobservable transition in BooleanMonitor using the same approach as #15
Close #7.