Skip to content

Conversation

@taiseiKMC
Copy link
Contributor

@taiseiKMC taiseiKMC commented Jan 7, 2026

Implement unobservable transition in BooleanMonitor using the same approach as #15

Close #7.

@taiseiKMC taiseiKMC changed the title Hsaito/issue 7 Resolve #7 Jan 7, 2026
@taiseiKMC taiseiKMC force-pushed the hsaito/issue-7 branch 2 times, most recently from 11f00a0 to e32257b Compare January 10, 2026 19:26
@taiseiKMC taiseiKMC marked this pull request as ready for review January 10, 2026 19:27
@MasWag MasWag requested review from MasWag and Copilot and removed request for Copilot January 11, 2026 01:41
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request implements epsilon (unobservable) transition support in the BooleanMonitor class, following the same approach used in PR #15 for the DataParametricMonitor. The implementation adds the ability to handle transitions labeled with action ID 127 (unobservable actions) that can occur without consuming input events.

Changes:

  • Implemented epsilon transition handling in BooleanMonitor with time advancement based on clock guards
  • Refactored test fixtures to support both boolean and data parametric monitors with improved naming conventions
  • Added comprehensive test coverage for epsilon transitions in various scenarios including guards, multiple clock variables, and accept state transitions

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
test/fixture/epsilon_transition_automaton_fixture.hh Added #pragma once, makeBooleanTA() method, made methods const, renamed constants to SCREAMING_SNAKE_CASE, and converted fixtures to inline const
test/data_parametric_monitor_test.cc Updated to use refactored fixture names (FIXTURE1-4) and consolidated fixture structure
test/boolean_monitor_test.cc Refactored with template-based fixtures and added four new epsilon transition test cases covering various scenarios
src/boolean_monitor.hh Added epsilon transition support: Configuration now tracks absolute time, implemented epsilonTransition() method, destructor calls epsilon transitions for final processing

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@MasWag MasWag merged commit cf60f08 into MasWag:master Jan 11, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support unobservable transitions in BooleanMonitor

2 participants