Improvements for summoned monsters

[sven-n]

• Don't cause self defense to be activated from attacking the own summoned monster
• No experience gains for killing summoned monsters
• Summons shouldn't attack the owner after the owner attacked it
• They are allowed to spawn in the safezone, to be able to follow a map change.

Based on some changes of #649

[gemini-code-assist]

Summary of Changes

Hello @sven-n, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces several quality-of-life and consistency improvements for summoned monsters within the game. The changes aim to refine their behavior by preventing unintended interactions such as self-defense triggers or experience gains from friendly fire, and by enhancing their ability to follow their owner by allowing them to traverse safe zones. These adjustments contribute to a more intuitive and balanced gameplay experience involving summoned entities.

Highlights

• Self-Defense Logic: Prevented self-defense from activating when a player attacks their own summoned monster.
• Experience and Item Drops: Ensured that killing summoned monsters does not yield experience or item drops.
• Summoned Monster Retaliation: Implemented logic to prevent summoned monsters from attacking their owner after being hit.
• Safe Zone Spawning and Movement: Allowed summoned monsters to spawn and walk in safe zones, enabling them to follow their owner across map changes.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces several valuable improvements for summoned monsters, including preventing experience gain from them, stopping them from attacking their owner, and allowing them to spawn in safe zones. The changes are logical and correctly implemented. A bug in the self-defense logic also appears to be fixed, which is a great addition. A new test case for the self-defense change is also included, which is good practice. I've added a few suggestions to refactor the duplicated logic for identifying summoned monsters into a single helper method to improve maintainability.