Support timeslides #233
Open
Support timeslides #233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepchatterjeeligo
approved these changes
Jun 3, 2025
Collaborator
deepchatterjeeligo
left a comment
deepchatterjeeligo
left a comment
There was a problem hiding this comment.
Just left a minor comment, but looks good otherwise. Approving.
Comment on lines
+548
to
+550
| gpstimes: np.ndarray, | ||
| fnames: List[Path], | ||
| timeslides: Optional[np.ndarray] = None, |
Collaborator
There was a problem hiding this comment.
should we raise a RunTimeError checking that the length of gpstimes and timeslides is the same.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support analyzing timeshifted data during testing step for
RawStrainTestingDataset