-
Notifications
You must be signed in to change notification settings - Fork 14
Torch Root finding #203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Torch Root finding #203
Conversation
deepchatterjeeligo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few thoughts.
- Let's make the auxiliary functions compatible with both numpy and torch depending on the input. This will ensure that the current features are maintained.
- Define a new module (maybe
solver.py) for the torch newton solver which will import the functions from above. - And another .py file called
healpix_utils.pythat contain the torch based healpux functions. - Add some testing for the core solver using simple polynomials or anything else you see fit. If you can add a test for the ansatz using the auxiliary functions in addition its even better.
|
ML4GW/ml4gw#193 should be merged before this |
|
If this is 10 times slower, why are we merging it in? |
I want to keep the feature, though not use it rightaway until the issue with the speed is resolved. My hope is that we will be able to improve on the speed once someone can take a closer look. |
|
Okay thats makes sense. I suggest we keep it as a draft PR then until someone has the chance to take a look. |
Use torch for most scipy/healpy functions
This version is much slower (~10 times) than the scipy/healpy equivalent.